Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSTransformValue.h

Issue 2683853005: bindings: Make some value iterator properties aliases to Array.prototype functions (Closed)
Patch Set: Remove constexpr from Internals.h to fix the Android build Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/cssom/CSSTransformValue.h
diff --git a/third_party/WebKit/Source/core/css/cssom/CSSTransformValue.h b/third_party/WebKit/Source/core/css/cssom/CSSTransformValue.h
index adbcc4ff1c3bcecab02a010e3b708479b150fbb7..5ceac85d5895eacf7e2b6cab2fe04e2b28d3345f 100644
--- a/third_party/WebKit/Source/core/css/cssom/CSSTransformValue.h
+++ b/third_party/WebKit/Source/core/css/cssom/CSSTransformValue.h
@@ -5,7 +5,6 @@
#ifndef CSSTransformValue_h
#define CSSTransformValue_h
-#include "bindings/core/v8/Iterable.h"
#include "bindings/core/v8/ScriptWrappable.h"
#include "core/CoreExport.h"
#include "core/css/cssom/CSSStyleValue.h"
@@ -14,9 +13,7 @@
namespace blink {
-class CORE_EXPORT CSSTransformValue final
- : public CSSStyleValue,
- public ValueIterable<CSSTransformComponent *> {
+class CORE_EXPORT CSSTransformValue final : public CSSStyleValue {
WTF_MAKE_NONCOPYABLE(CSSTransformValue);
DEFINE_WRAPPERTYPEINFO();
@@ -36,11 +33,11 @@ class CORE_EXPORT CSSTransformValue final
StyleValueType type() const override { return TransformType; }
- CSSTransformComponent* componentAtIndex(int index) {
+ CSSTransformComponent* componentAtIndex(uint32_t index) {
return m_transformComponents.at(index);
}
- size_t size() { return m_transformComponents.size(); }
+ size_t length() const { return m_transformComponents.size(); }
DEFINE_INLINE_VIRTUAL_TRACE() {
visitor->trace(m_transformComponents);
@@ -54,8 +51,6 @@ class CORE_EXPORT CSSTransformValue final
: CSSStyleValue(), m_transformComponents(transformComponents) {}
HeapVector<Member<CSSTransformComponent>> m_transformComponents;
-
- IterationSource* startIteration(ScriptState*, ExceptionState&) override;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698