Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSTransformValue.cpp

Issue 2683853005: bindings: Make some value iterator properties aliases to Array.prototype functions (Closed)
Patch Set: Remove constexpr from Internals.h to fix the Android build Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/cssom/CSSTransformValue.cpp
diff --git a/third_party/WebKit/Source/core/css/cssom/CSSTransformValue.cpp b/third_party/WebKit/Source/core/css/cssom/CSSTransformValue.cpp
index 35679f9e3e70ee046a2b455495c20a4f31ed2d46..a2a51bccc5f57c45d7810a76424710b89fe3753b 100644
--- a/third_party/WebKit/Source/core/css/cssom/CSSTransformValue.cpp
+++ b/third_party/WebKit/Source/core/css/cssom/CSSTransformValue.cpp
@@ -9,35 +9,6 @@
namespace blink {
-namespace {
-
-class TransformValueIterationSource final
- : public ValueIterable<CSSTransformComponent*>::IterationSource {
- public:
- explicit TransformValueIterationSource(CSSTransformValue* transformValue)
- : m_transformValue(transformValue) {}
-
- bool next(ScriptState*,
- CSSTransformComponent*& value,
- ExceptionState&) override {
- if (m_index >= m_transformValue->size()) {
- return false;
- }
- value = m_transformValue->componentAtIndex(m_index);
- return true;
- }
-
- DEFINE_INLINE_VIRTUAL_TRACE() {
- visitor->trace(m_transformValue);
- ValueIterable<CSSTransformComponent*>::IterationSource::trace(visitor);
- }
-
- private:
- const Member<CSSTransformValue> m_transformValue;
-};
-
-} // namespace
-
CSSTransformValue* CSSTransformValue::fromCSSValue(const CSSValue& cssValue) {
if (!cssValue.isValueList()) {
// TODO(meade): Also need to check the separator here if we care.
@@ -54,11 +25,6 @@ CSSTransformValue* CSSTransformValue::fromCSSValue(const CSSValue& cssValue) {
return CSSTransformValue::create(components);
}
-ValueIterable<CSSTransformComponent*>::IterationSource*
-CSSTransformValue::startIteration(ScriptState*, ExceptionState&) {
- return new TransformValueIterationSource(this);
-}
-
bool CSSTransformValue::is2D() const {
for (size_t i = 0; i < m_transformComponents.size(); i++) {
if (!m_transformComponents[i]->is2D()) {

Powered by Google App Engine
This is Rietveld 408576698