harmony: update extension install dialog

harmony: update extension install dialog

This change:
1) Moves the "View details" link down to the extra view slot in the dialog;
2) Updates the text of that link to "Open in Web Store"

BUG=605657
Review-Url: https://codereview.chromium.org/2683843004
Cr-Commit-Position: refs/heads/master@{#449946}
Committed: https://chromium.googlesource.com/chromium/src/+/191eab692b8168b5d14058cde811edf8228e4532

[Elly Fong-Jones, 2017-02-08 15:46:20]

Description was changed from

==========
harmony: update extension install dialog

This change:
1) Moves the "View details" link down to the extra view slot in the dialog;
2) Updates the text of that link to "Open in Web Store"

BUG=605657
==========

to

==========
harmony: update extension install dialog

This change:
1) Moves the "View details" link down to the extra view slot in the dialog;
2) Updates the text of that link to "Open in Web Store"

BUG=605657
==========

[Elly Fong-Jones, 2017-02-08 15:46:20]

ellyjones@chromium.org changed reviewers:
+ benwells@chromium.org, pkasting@chromium.org

[Elly Fong-Jones, 2017-02-08 15:46:31]

benwells@, pkasting@: ptal? :)

[benwells, 2017-02-10 01:56:07]

lgtm

https://codereview.chromium.org/2683843004/diff/1/chrome/browser/ui/views/ext...
File chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
(right):

https://codereview.chromium.org/2683843004/diff/1/chrome/browser/ui/views/ext...
chrome/browser/ui/views/extensions/extension_install_dialog_view.cc:557: return
nullptr;
optional nit: newline after return.

[benwells, 2017-02-10 01:56:07]

lgtm

lgtm

https://codereview.chromium.org/2683843004/diff/1/chrome/browser/ui/views/ext...
File chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
(right):

https://codereview.chromium.org/2683843004/diff/1/chrome/browser/ui/views/ext...
chrome/browser/ui/views/extensions/extension_install_dialog_view.cc:557: return
nullptr;
optional nit: newline after return.

[Elly Fong-Jones, 2017-02-10 16:28:07]

pkasting: ptal? :)

https://codereview.chromium.org/2683843004/diff/1/chrome/browser/ui/views/ext...
File chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
(right):

https://codereview.chromium.org/2683843004/diff/1/chrome/browser/ui/views/ext...
chrome/browser/ui/views/extensions/extension_install_dialog_view.cc:557: return
nullptr;
On 2017/02/10 01:56:06, benwells wrote:
> optional nit: newline after return.

Done.

[Peter Kasting, 2017-02-11 04:31:52]

LGTM

[Elly Fong-Jones, 2017-02-13 13:27:26]

The CQ bit was checked by ellyjones@chromium.org

[Elly Fong-Jones, 2017-02-13 13:27:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
benwells@chromium.org
Link to the patchset: https://codereview.chromium.org/2683843004/#ps20001
(title: "add newline")

[commit-bot: I haz the power, 2017-02-13 13:27:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 14:08:08]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486992446364370,
"parent_rev": "ab58303a76a0ced3a777aca31af15eb5d6e9185a", "commit_rev":
"191eab692b8168b5d14058cde811edf8228e4532"}

[commit-bot: I haz the power, 2017-02-13 14:08:46]

Description was changed from

==========
harmony: update extension install dialog

This change:
1) Moves the "View details" link down to the extra view slot in the dialog;
2) Updates the text of that link to "Open in Web Store"

BUG=605657
==========

to

==========
harmony: update extension install dialog

This change:
1) Moves the "View details" link down to the extra view slot in the dialog;
2) Updates the text of that link to "Open in Web Store"

BUG=605657

Review-Url: https://codereview.chromium.org/2683843004
Cr-Commit-Position: refs/heads/master@{#449946}
Committed:
https://chromium.googlesource.com/chromium/src/+/191eab692b8168b5d14058cde811...
==========

[commit-bot: I haz the power, 2017-02-13 14:08:47]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/191eab692b8168b5d14058cde811...