Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: content/browser/web_contents/web_contents_view_android.cc

Issue 2683823002: Disable DateTime, Color, and Select popups when in VR (Closed)
Patch Set: reformat todo's Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_view_android.cc
diff --git a/content/browser/web_contents/web_contents_view_android.cc b/content/browser/web_contents/web_contents_view_android.cc
index 21b2fbc64d8f491ca6b3747af9e3b858c3a23627..eff31dae4267fc85a5c20bc3aa8409b30309fde9 100644
--- a/content/browser/web_contents/web_contents_view_android.cc
+++ b/content/browser/web_contents/web_contents_view_android.cc
@@ -276,6 +276,12 @@ void WebContentsViewAndroid::ShowPopupMenu(
const std::vector<MenuItem>& items,
bool right_aligned,
bool allow_multiple_selection) {
+ if (web_contents_->GetRenderWidgetHostView()->IsInVR()) {
+ // TODO(billorr): Add VR select popup support. See crbug.com/661243.
+ NOTIMPLEMENTED();
+ return;
+ }
+
if (content_view_core_) {
content_view_core_->ShowSelectPopupMenu(
render_frame_host, bounds, items, selected_item,

Powered by Google App Engine
This is Rietveld 408576698