Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2683823002: Disable DateTime, Color, and Select popups when in VR (Closed)
Patch Set: reformat todo's Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 01a810115cad34d45f09f089116e46209c11b174..56518b7d1ffa278ac3cfc515bb4bc570551b8d13 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -3727,6 +3727,12 @@ void WebContentsImpl::OnGetNearestFindResultReply(RenderFrameHostImpl* source,
void WebContentsImpl::OnOpenDateTimeDialog(
RenderViewHostImpl* source,
const ViewHostMsg_DateTimeDialogValue_Params& value) {
+ if (GetRenderWidgetHostView()->IsInVR()) {
+ // TODO(billorr): Add VR datetime chooser support. See crbug.com/688122.
+ NOTIMPLEMENTED();
+ return;
+ }
+
date_time_chooser_->ShowDialog(
GetTopLevelNativeWindow(), source, value.dialog_type, value.dialog_value,
value.minimum, value.maximum, value.step, value.suggestions);

Powered by Google App Engine
This is Rietveld 408576698