Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Side by Side Diff: chrome/browser/resources/extensions/extension_list.js

Issue 2683793005: Let disabled/terminated extensions show ErrorConsole. (Closed)
Patch Set: sync Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // <include src="extension_error.js"> 5 // <include src="extension_error.js">
6 6
7 cr.define('extensions', function() { 7 cr.define('extensions', function() {
8 'use strict'; 8 'use strict';
9 9
10 var ExtensionType = chrome.developerPrivate.ExtensionType; 10 var ExtensionType = chrome.developerPrivate.ExtensionType;
(...skipping 446 matching lines...) Expand 10 before | Expand all | Expand 10 after
457 457
458 // The 'Reload' link. 458 // The 'Reload' link.
459 wrapper.setupColumn('localReload', '.reload-link', 'click', function(e) { 459 wrapper.setupColumn('localReload', '.reload-link', 'click', function(e) {
460 chrome.developerPrivate.reload(extension.id, {failQuietly: true}); 460 chrome.developerPrivate.reload(extension.id, {failQuietly: true});
461 }); 461 });
462 462
463 wrapper.setupColumn('errors', '.errors-link', 'click', function(e) { 463 wrapper.setupColumn('errors', '.errors-link', 'click', function(e) {
464 var extensionId = extension.id; 464 var extensionId = extension.id;
465 assert(this.extensions_.length > 0); 465 assert(this.extensions_.length > 0);
466 var newEx = this.extensions_.filter(function(e) { 466 var newEx = this.extensions_.filter(function(e) {
467 return e.state == chrome.developerPrivate.ExtensionState.ENABLED && 467 return e.id == extensionId;
468 e.id == extensionId;
469 })[0]; 468 })[0];
470 var errors = newEx.manifestErrors.concat(newEx.runtimeErrors); 469 var errors = newEx.manifestErrors.concat(newEx.runtimeErrors);
471 extensions.ExtensionErrorOverlay.getInstance().setErrorsAndShowOverlay( 470 extensions.ExtensionErrorOverlay.getInstance().setErrorsAndShowOverlay(
472 errors, extensionId, newEx.name); 471 errors, extensionId, newEx.name);
473 }.bind(this)); 472 }.bind(this));
474 473
475 wrapper.setupColumn('suspiciousLearnMore', 474 wrapper.setupColumn('suspiciousLearnMore',
476 '.suspicious-install-message .learn-more-link'); 475 '.suspicious-install-message .learn-more-link');
477 476
478 // The path, if provided by unpacked extension. 477 // The path, if provided by unpacked extension.
(...skipping 589 matching lines...) Expand 10 before | Expand all | Expand 10 after
1068 this.createWrapper_(extension, nextExt ? $(nextExt.id) : null); 1067 this.createWrapper_(extension, nextExt ? $(nextExt.id) : null);
1069 } 1068 }
1070 } 1069 }
1071 }; 1070 };
1072 1071
1073 return { 1072 return {
1074 ExtensionList: ExtensionList, 1073 ExtensionList: ExtensionList,
1075 ExtensionListDelegate: ExtensionListDelegate 1074 ExtensionListDelegate: ExtensionListDelegate
1076 }; 1075 };
1077 }); 1076 });
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698