Chromium Code Reviews
DescriptionRevert of [Blink>Media] Fix a crash in autoplay caused by delayed visibility observation (patchset #1 id:1 of https://codereview.chromium.org/2671993002/ )
Reason for revert:
Decided to fix the issue in IntersectionObserver instead of HTMLMediaElement. This CL will be reverted and be superseded by the new fix.
Original issue's description:
> [Blink>Media] Fix a crash in autoplay caused by delayed visibility observation
>
> There is a crash caused by delayed visibility observation after an
> autoplay muted video gets unmuted, so that HTMLMediaElement tries to
> stop the observer twice. However the pointer to the observer is set to
> null on stop, thus a crash happens.
>
> This CL adds null-check in
> HTMLMediaElement::onVisibilityChangedForAutoplay() to avoid the crash.
>
> BUG=686458
>
> Review-Url: https://codereview.chromium.org/2671993002
> Cr-Commit-Position: refs/heads/master@{#448641}
> Committed: https://chromium.googlesource.com/chromium/src/+/0268543786283db4107d2362f338901d909545b1
TBR=mlamouri@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=686458
Review-Url: https://codereview.chromium.org/2683783002
Cr-Commit-Position: refs/heads/master@{#448727}
Committed: https://chromium.googlesource.com/chromium/src/+/a00cedc6b6caf3fdf88bba8f4dba6b6fcda64a3e
Patch Set 1 #
Messages
Total messages: 8 (4 generated)
|
|||||||||||||||||||