Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2683783002: Revert of [Blink>Media] Fix a crash in autoplay caused by delayed visibility observation (Closed)

Created:
3 years, 10 months ago by Zhiqiang Zhang (Slow)
Modified:
3 years, 10 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, nessy, Srirama
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Blink>Media] Fix a crash in autoplay caused by delayed visibility observation (patchset #1 id:1 of https://codereview.chromium.org/2671993002/ ) Reason for revert: Decided to fix the issue in IntersectionObserver instead of HTMLMediaElement. This CL will be reverted and be superseded by the new fix. Original issue's description: > [Blink>Media] Fix a crash in autoplay caused by delayed visibility observation > > There is a crash caused by delayed visibility observation after an > autoplay muted video gets unmuted, so that HTMLMediaElement tries to > stop the observer twice. However the pointer to the observer is set to > null on stop, thus a crash happens. > > This CL adds null-check in > HTMLMediaElement::onVisibilityChangedForAutoplay() to avoid the crash. > > BUG=686458 > > Review-Url: https://codereview.chromium.org/2671993002 > Cr-Commit-Position: refs/heads/master@{#448641} > Committed: https://chromium.googlesource.com/chromium/src/+/0268543786283db4107d2362f338901d909545b1 TBR=mlamouri@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=686458 Review-Url: https://codereview.chromium.org/2683783002 Cr-Commit-Position: refs/heads/master@{#448727} Committed: https://chromium.googlesource.com/chromium/src/+/a00cedc6b6caf3fdf88bba8f4dba6b6fcda64a3e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Zhiqiang Zhang (Slow)
Created Revert of [Blink>Media] Fix a crash in autoplay caused by delayed visibility observation
3 years, 10 months ago (2017-02-07 20:45:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683783002/1
3 years, 10 months ago (2017-02-07 20:47:07 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/a00cedc6b6caf3fdf88bba8f4dba6b6fcda64a3e
3 years, 10 months ago (2017-02-07 20:48:23 UTC) #6
Zhiqiang Zhang (Slow)
3 years, 10 months ago (2017-02-07 20:48:28 UTC) #8
Message was sent while issue was closed.
+szager FYI

Powered by Google App Engine
This is Rietveld 408576698