Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2683773004: Fix missed invalidation in markFixedPositionObjectForLayoutIfNeeded. (Closed)

Created:
3 years, 10 months ago by skobes
Modified:
3 years, 10 months ago
Reviewers:
szager1
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix missed invalidation in markFixedPositionObjectForLayoutIfNeeded. If a fixed-position element had "auto" offsets in both block and inline flow directions, the LayoutOnlyFixedPositionedObjects codepath failed to mark it for layout when its computed logical top changed. BUG=674867 Review-Url: https://codereview.chromium.org/2683773004 Cr-Commit-Position: refs/heads/master@{#448889} Committed: https://chromium.googlesource.com/chromium/src/+/ccf2862c092b2339e42d7131d219b18060a773a7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/block/positioning/fixed-in-abs-in-rel-top-change.html View 1 chunk +29 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
skobes
3 years, 10 months ago (2017-02-08 01:19:32 UTC) #5
szager1
gross lgtm
3 years, 10 months ago (2017-02-08 01:23:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683773004/1
3 years, 10 months ago (2017-02-08 01:26:01 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 03:18:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ccf2862c092b2339e42d7131d219...

Powered by Google App Engine
This is Rietveld 408576698