Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2683763004: Pass MouseUp to the captured scrollbar animation controller in layer tree (Closed)

Created:
3 years, 10 months ago by chaopeng
Modified:
3 years, 10 months ago
Reviewers:
bokan, weiliangc
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass MouseUp to the captured scrollbar animation controller in layer tree. This issue is caused by we only pass the MouseUp to the scoll layer currently mouse over. If we capture the scrollbar then move to another scoll layer then the captured scrollbar will lose the MouseUp. In this patch we save the captured_scrollbar_animation_controller when mouse down so that we can call the captured_scrollbar_animation_controller MouseUp. BUG=690052 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2683763004 Cr-Commit-Position: refs/heads/master@{#449986} Committed: https://chromium.googlesource.com/chromium/src/+/7250e1ab8f60d4a7ad8644c11ed0576f2c4f34b1

Patch Set 1 #

Total comments: 1

Patch Set 2 : record captured_animation_controller_ for mouse up #

Total comments: 1

Patch Set 3 : bokan's comment addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
M cc/trees/layer_tree_host_impl.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 2 chunks +8 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (18 generated)
chaopeng
PTAL. Thank you.
3 years, 10 months ago (2017-02-08 20:31:37 UTC) #3
bokan
https://codereview.chromium.org/2683763004/diff/1/cc/trees/layer_tree_host_impl.cc File cc/trees/layer_tree_host_impl.cc (right): https://codereview.chromium.org/2683763004/diff/1/cc/trees/layer_tree_host_impl.cc#newcode3243 cc/trees/layer_tree_host_impl.cc:3243: for (auto& pair : scrollbar_animation_controllers_) This only needs to ...
3 years, 10 months ago (2017-02-10 15:56:41 UTC) #4
chaopeng
On 2017/02/10 15:56:41, bokan wrote: > https://codereview.chromium.org/2683763004/diff/1/cc/trees/layer_tree_host_impl.cc > File cc/trees/layer_tree_host_impl.cc (right): > > https://codereview.chromium.org/2683763004/diff/1/cc/trees/layer_tree_host_impl.cc#newcode3243 > ...
3 years, 10 months ago (2017-02-10 16:11:52 UTC) #5
chaopeng
weiliangc@chromium.org: PTAL, Thank you.
3 years, 10 months ago (2017-02-10 16:14:14 UTC) #7
bokan
lgtm https://codereview.chromium.org/2683763004/diff/20001/cc/trees/layer_tree_host_impl.h File cc/trees/layer_tree_host_impl.h (right): https://codereview.chromium.org/2683763004/diff/20001/cc/trees/layer_tree_host_impl.h#newcode797 cc/trees/layer_tree_host_impl.h:797: ScrollbarAnimationController* captured_animation_controller_; captured_scrollbar_animation_controller_
3 years, 10 months ago (2017-02-10 16:53:48 UTC) #8
weiliangc
lgtm
3 years, 10 months ago (2017-02-13 16:20:30 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683763004/80001
3 years, 10 months ago (2017-02-13 16:22:59 UTC) #23
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 17:15:22 UTC) #26
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/7250e1ab8f60d4a7ad8644c11ed0...

Powered by Google App Engine
This is Rietveld 408576698