Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 2683703003: [Mac hermetic] Latest ibtoold needs iPhoneSimulator platform files to compile mac xibs. (Closed)

Created:
3 years, 10 months ago by justincohen
Modified:
3 years, 10 months ago
Reviewers:
erikchen
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac hermetic] Latest ibtoold needs iPhoneSimulator platform files to compile mac xibs. This appears to be necessary on macOS 10.12.3. BUG=669240 Review-Url: https://codereview.chromium.org/2683703003 Cr-Commit-Position: refs/heads/master@{#448821} Committed: https://chromium.googlesource.com/chromium/src/+/62d09b768b1c27511fcaa6c9dd0cd30f093e8fbf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/package_mac_toolchain.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
erikchen
lgtm
3 years, 10 months ago (2017-02-07 23:45:14 UTC) #2
erikchen
On 2017/02/07 23:45:14, erikchen wrote: > lgtm Can you add a crbug?
3 years, 10 months ago (2017-02-07 23:45:29 UTC) #3
erikchen
On 2017/02/07 23:45:29, erikchen wrote: > On 2017/02/07 23:45:14, erikchen wrote: > > lgtm > ...
3 years, 10 months ago (2017-02-07 23:46:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683703003/1
3 years, 10 months ago (2017-02-08 00:04:07 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 00:38:57 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/62d09b768b1c27511fcaa6c9dd0c...

Powered by Google App Engine
This is Rietveld 408576698