Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2683663002: Add AddChildFrameSink() and RemoveChildFrameSink() To WindowAndroidCompositor (Closed)

Created:
3 years, 10 months ago by Alex Z.
Modified:
3 years, 10 months ago
Reviewers:
Fady Samuel, boliu
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add AddChildFrameSink() and RemoveChildFrameSink() To WindowAndroidCompositor DelegatedFrameHostAndroid calls WindowAndroidCompositor::AddChildFrameSink() and RemoveChildFrameSink() when it needs to attach to/detach from a compositor. CompositorImpl manages an unordered set of pending FrameSinkIds that emulates the message queue in mojo on desktop Chrome. In the future, the FrameSinkId will be invalidated during gpu restart. This change ensures that SurfaceManager::RegisterHierarchy() only gets called when the root window has a valid FrameSinkId. BUG=673543 Review-Url: https://codereview.chromium.org/2683663002 Cr-Commit-Position: refs/heads/master@{#448665} Committed: https://chromium.googlesource.com/chromium/src/+/aa231112e50ded728119bba18dfd4d93d596f00f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -21 lines) Patch
M content/browser/renderer_host/compositor_impl_android.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 4 chunks +29 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M ui/android/delegated_frame_host_android.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/android/delegated_frame_host_android.cc View 2 chunks +11 lines, -12 lines 0 comments Download
M ui/android/window_android_compositor.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Alex Z.
This CL contains the changes in Android code from my previous DirectCompositorFrameSink CL (https://codereview.chromium.org/2612083002/). PTAL.
3 years, 10 months ago (2017-02-07 16:20:44 UTC) #4
Fady Samuel
lgtm
3 years, 10 months ago (2017-02-07 16:56:04 UTC) #5
boliu
lgtm
3 years, 10 months ago (2017-02-07 17:43:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683663002/1
3 years, 10 months ago (2017-02-07 17:48:56 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 17:54:07 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/aa231112e50ded728119bba18dfd...

Powered by Google App Engine
This is Rietveld 408576698