Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 2683633004: predictors: Add subresources count and prefetching duration histograms. (Closed)

Created:
3 years, 10 months ago by alexilin
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

predictors: Add subresources count and prefetching duration histograms. This CL adds two more histograms for ResourcePrefetchPredictor trial. ResourcePrefetchPredictor.LearningCount shows how many useful subresources are contained in the database during prefetch predictor learning. ResourcePrefetchPredictor.PrefetchingDuration allows to estimate time window available for prefetching. BUG=680049 Review-Url: https://codereview.chromium.org/2683633004 Cr-Commit-Position: refs/heads/master@{#449331} Committed: https://chromium.googlesource.com/chromium/src/+/c374785047c1c350a944dc1836cc254c27cc0329

Patch Set 1 #

Patch Set 2 : Add descriptions to histograms.xml. #

Total comments: 6

Patch Set 3 : Nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -1 line) Patch
M chrome/browser/predictors/resource_prefetch_predictor.h View 1 2 4 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor.cc View 1 2 4 chunks +23 lines, -0 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_unittest.cc View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
alexilin
asvitkine: please review histograms.xml, thanks! lizeb: everything, as usual
3 years, 10 months ago (2017-02-08 10:31:59 UTC) #2
Alexei Svitkine (slow)
lgtm
3 years, 10 months ago (2017-02-08 16:32:32 UTC) #7
Benoit L
lgtm, but let's see how to coordinate with https://codereview.chromium.org/2688633002/, as some code may be duplicated ...
3 years, 10 months ago (2017-02-09 02:24:52 UTC) #8
alexilin
I've checked your CL, there is no duplication. We can't merge inflight_prefetches and prefetcher_stats because ...
3 years, 10 months ago (2017-02-09 15:50:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683633004/40001
3 years, 10 months ago (2017-02-09 15:51:18 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 17:18:57 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c374785047c1c350a944dc1836cc...

Powered by Google App Engine
This is Rietveld 408576698