Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 2683633003: Revert of Switch mash_browser_tests to Ozone X11 platform. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
Reviewers:
kylechar, sky
CC:
chromium-reviews, sadrul, rjkroege
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Switch mash_browser_tests to Ozone X11 platform. (patchset #10 id:210001 of https://codereview.chromium.org/2675443002/ ) Reason for revert: Looks like the only culprit that caused win bots to fail compile, i.e. https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium%2FWin%2F51649%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout Original issue's description: > Switch mash_browser_tests to Ozone X11 platform. > > Run with mash_browser_tests with Ozone X11 platform instead of Ozone > headless. Move most of the test arguments into the gn_isolate_map.pyl > file so they don't have to be repeated. Also add a proper dependency on > mash_service_overrides.json so that isolate knows the file is required > for mash_browser_tests. > > BUG=664570 > > Review-Url: https://codereview.chromium.org/2675443002 > Cr-Commit-Position: refs/heads/master@{#448703} > Committed: https://chromium.googlesource.com/chromium/src/+/18eef539260cdf6ca1f5dbfbb0a44cbf836a5824 TBR=sky@chromium.org,kylechar@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=664570 Review-Url: https://codereview.chromium.org/2683633003 Cr-Commit-Position: refs/heads/master@{#448728} Committed: https://chromium.googlesource.com/chromium/src/+/fc72782d44b71f6a1d8b38f264c9119dcb6cea65

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -44 lines) Patch
M chrome/app/mash/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 2 chunks +16 lines, -10 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 2 chunks +18 lines, -12 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
jam
Created Revert of Switch mash_browser_tests to Ozone X11 platform.
3 years, 10 months ago (2017-02-07 21:14:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683633003/1
3 years, 10 months ago (2017-02-07 21:15:39 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/fc72782d44b71f6a1d8b38f264c9119dcb6cea65
3 years, 10 months ago (2017-02-07 21:17:47 UTC) #6
sky
3 years, 10 months ago (2017-02-07 21:19:50 UTC) #7
Message was sent while issue was closed.
On 2017/02/07 21:15:39, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

The last successful compile on windows did not compile mus_property_mirror_ash.
The failing compile was compiling it.

Powered by Google App Engine
This is Rietveld 408576698