Get rid of sync_preferences::SyncedPrefObserver inheritance.

Get rid of sync_preferences::SyncedPrefObserver inheritance.

ArcSessionManager inherits SyncedPrefObserver, but it is not
used now, because kArcEnabled is not sync pref.
The callback is called from OnOptInPreferenceChanged() only,
so this CL inlines the function to there.

This is preparation to extract preference handling from
ArcSessionManager into a dedicated class.

BUG=657687
BUG=b/31079732
TEST=Ran bots. Made sure "removing pinned icon from shelf" works manually.

Review-Url: https://codereview.chromium.org/2683613002
Cr-Commit-Position: refs/heads/master@{#448878}
Committed: https://chromium.googlesource.com/chromium/src/+/32e8ee260dfbd9c3da830f2c9cde9eddadfaf40f

[hidehiko, 2017-02-07 13:18:16]

The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 13:18:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 13:46:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 13:46:09]

Dry run: This issue passed the CQ dry run.

[hidehiko, 2017-02-07 14:03:49]

hidehiko@chromium.org changed reviewers:
+ lhchavez@chromium.org, skuhne@chromium.org

[hidehiko, 2017-02-07 14:03:50]

PTAL.

[hidehiko, 2017-02-07 14:05:37]

https://codereview.chromium.org/2683613002/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/arc_session_manager.cc (left):

https://codereview.chromium.org/2683613002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_session_manager.cc:458: if (IsArcEnabled())
Note: according to
https://codereview.chromium.org/1854463002/diff/1/chrome/browser/chromeos/arc...,
this was workaround when we're using sync pref. Though, now we are using
non-sync one, so we should be able to drop this safely.

[Luis Héctor Chávez, 2017-02-07 16:35:41]

lgtm

[Mr4D (OOO till 08-26), 2017-02-07 16:59:23]

lgtm

[hidehiko, 2017-02-08 02:49:37]

The CQ bit was checked by hidehiko@chromium.org

[commit-bot: I haz the power, 2017-02-08 02:50:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 02:56:46]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486522177173540, "parent_rev":
"82138dd6e5ce3b1ec4f5f571dd4935885e1f6db5", "commit_rev":
"32e8ee260dfbd9c3da830f2c9cde9eddadfaf40f"}

[commit-bot: I haz the power, 2017-02-08 02:57:29]

Description was changed from

==========
Get rid of sync_preferences::SyncedPrefObserver inheritance.

ArcSessionManager inherits SyncedPrefObserver, but it is not
used now, because kArcEnabled is not sync pref.
The callback is called from OnOptInPreferenceChanged() only,
so this CL inlines the function to there.

This is preparation to extract preference handling from
ArcSessionManager into a dedicated class.

BUG=657687
BUG=b/31079732
TEST=Ran bots. Made sure "removing pinned icon from shelf" works manually.
==========

to

==========
Get rid of sync_preferences::SyncedPrefObserver inheritance.

ArcSessionManager inherits SyncedPrefObserver, but it is not
used now, because kArcEnabled is not sync pref.
The callback is called from OnOptInPreferenceChanged() only,
so this CL inlines the function to there.

This is preparation to extract preference handling from
ArcSessionManager into a dedicated class.

BUG=657687
BUG=b/31079732
TEST=Ran bots. Made sure "removing pinned icon from shelf" works manually.

Review-Url: https://codereview.chromium.org/2683613002
Cr-Commit-Position: refs/heads/master@{#448878}
Committed:
https://chromium.googlesource.com/chromium/src/+/32e8ee260dfbd9c3da830f2c9cde...
==========

[commit-bot: I haz the power, 2017-02-08 02:57:31]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/32e8ee260dfbd9c3da830f2c9cde...