Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2683603002: FlatDomTreeExtractor to enable & disable DOM domain (Closed)

Created:
3 years, 10 months ago by alex clarke (OOO till 29th)
Modified:
3 years, 9 months ago
Reviewers:
Sami
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

FlatDomTreeExtractor to enable & disable DOM domain A quality of life change intended to make FlatDomTreeExtractorBrowserTest easier to use. BUG=546953 Review-Url: https://codereview.chromium.org/2683603002 Cr-Commit-Position: refs/heads/master@{#448623} Committed: https://chromium.googlesource.com/chromium/src/+/d5d3679ab3655f079e9b1d019be993ff1e7dacf6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M headless/public/util/flat_dom_tree_extractor.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M headless/public/util/flat_dom_tree_extractor_browsertest.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
alex clarke (OOO till 29th)
PTAL
3 years, 10 months ago (2017-02-07 12:36:32 UTC) #4
Sami
lgtm (although the patch description sounds like the opposite of what you're doing)
3 years, 10 months ago (2017-02-07 14:40:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683603002/1
3 years, 10 months ago (2017-02-07 15:04:01 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/d5d3679ab3655f079e9b1d019be993ff1e7dacf6
3 years, 10 months ago (2017-02-07 15:08:32 UTC) #13
john88tin
3 years, 9 months ago (2017-03-08 16:14:18 UTC) #14
Message was sent while issue was closed.
On 2017/02/07 14:40:13, Sami wrote:
> lgtm (although the patch description sounds like the opposite of what you're
> doing)

Powered by Google App Engine
This is Rietveld 408576698