Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: chrome/browser/resources/settings/languages_page/languages_page.html

Issue 2683583008: MD Settings: Convert spell-check from checkbox to toggle. (Closed)
Patch Set: no more overlapping handler Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/languages_page/languages_page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/languages_page/languages_page.html
diff --git a/chrome/browser/resources/settings/languages_page/languages_page.html b/chrome/browser/resources/settings/languages_page/languages_page.html
index 85b8e7cc67a2baebbae05a99f908b4c8c4938ae0..09da2a7646c5355d3fc29edf8ffd4cffef6fc38d 100644
--- a/chrome/browser/resources/settings/languages_page/languages_page.html
+++ b/chrome/browser/resources/settings/languages_page/languages_page.html
@@ -203,14 +203,16 @@
<iron-collapse id="spellCheckCollapse" opened="[[spellCheckOpened_]]">
<div class="list-frame vertical-list">
<template is="dom-repeat" items="[[languages.enabled]]">
- <div class="list-item">
- <paper-checkbox
- checked="[[item.spellCheckEnabled]]"
- on-change="onSpellCheckChange_"
- disabled$="[[!item.language.supportsSpellcheck]]">
+ <div class="list-item"
+ actionable$="[[item.language.supportsSpellcheck]]">
Dan Beam 2017/02/11 03:10:47 i think you should move the actionable$= to the ex
scottchen 2017/02/13 20:05:52 Done.
+ <div class="start" on-tap="onSpellCheckChange_">
[[item.language.displayName]]
- </paper-checkbox>
- </label>
+ </div>
+ <paper-toggle-button on-change="onSpellCheckChange_"
+ disabled="[[!item.language.supportsSpellcheck]]"
+ checked="[[item.spellCheckEnabled]]">
+ </paper-toggle-button>
+ </div>
</template>
<div class="list-item">
<a is="action-link" class="list-button"
« no previous file with comments | « no previous file | chrome/browser/resources/settings/languages_page/languages_page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698