Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Side by Side Diff: chrome/browser/resources/settings/languages_page/languages_page.html

Issue 2683583008: MD Settings: Convert spell-check from checkbox to toggle. (Closed)
Patch Set: no more overlapping handler Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/languages_page/languages_page.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/action_link.html"> 1 <link rel="import" href="chrome://resources/html/action_link.html">
2 <link rel="import" href="chrome://resources/html/action_link_css.html"> 2 <link rel="import" href="chrome://resources/html/action_link_css.html">
3 <link rel="import" href="chrome://resources/html/assert.html"> 3 <link rel="import" href="chrome://resources/html/assert.html">
4 <link rel="import" href="chrome://resources/html/cr.html"> 4 <link rel="import" href="chrome://resources/html/cr.html">
5 <link rel="import" href="chrome://resources/html/polymer.html"> 5 <link rel="import" href="chrome://resources/html/polymer.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-coll apse.html"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-coll apse.html">
7 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html"> 7 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html">
8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html"> 8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html">
9 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 9 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
10 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action _menu.html"> 10 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action _menu.html">
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
196 <div>$i18n{spellCheckListTitle}</div> 196 <div>$i18n{spellCheckListTitle}</div>
197 <div class="secondary">[[spellCheckSecondaryText_]]</div> 197 <div class="secondary">[[spellCheckSecondaryText_]]</div>
198 </div> 198 </div>
199 <cr-expand-button expanded="{{spellCheckOpened_}}" 199 <cr-expand-button expanded="{{spellCheckOpened_}}"
200 alt="$i18n{spellCheckExpandA11yLabel}"> 200 alt="$i18n{spellCheckExpandA11yLabel}">
201 </cr-expand-button> 201 </cr-expand-button>
202 </div> 202 </div>
203 <iron-collapse id="spellCheckCollapse" opened="[[spellCheckOpened_]]"> 203 <iron-collapse id="spellCheckCollapse" opened="[[spellCheckOpened_]]">
204 <div class="list-frame vertical-list"> 204 <div class="list-frame vertical-list">
205 <template is="dom-repeat" items="[[languages.enabled]]"> 205 <template is="dom-repeat" items="[[languages.enabled]]">
206 <div class="list-item"> 206 <div class="list-item"
207 <paper-checkbox 207 actionable$="[[item.language.supportsSpellcheck]]">
Dan Beam 2017/02/11 03:10:47 i think you should move the actionable$= to the ex
scottchen 2017/02/13 20:05:52 Done.
208 checked="[[item.spellCheckEnabled]]" 208 <div class="start" on-tap="onSpellCheckChange_">
209 on-change="onSpellCheckChange_"
210 disabled$="[[!item.language.supportsSpellcheck]]">
211 [[item.language.displayName]] 209 [[item.language.displayName]]
212 </paper-checkbox> 210 </div>
213 </label> 211 <paper-toggle-button on-change="onSpellCheckChange_"
212 disabled="[[!item.language.supportsSpellcheck]]"
213 checked="[[item.spellCheckEnabled]]">
214 </paper-toggle-button>
215 </div>
214 </template> 216 </template>
215 <div class="list-item"> 217 <div class="list-item">
216 <a is="action-link" class="list-button" 218 <a is="action-link" class="list-button"
217 on-tap="onEditDictionaryTap_"> 219 on-tap="onEditDictionaryTap_">
218 $i18n{manageSpellCheck} 220 $i18n{manageSpellCheck}
219 </a> 221 </a>
220 </div> 222 </div>
221 </div> 223 </div>
222 </iron-collapse> 224 </iron-collapse>
223 </if> 225 </if>
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
291 </if> 293 </if>
292 </settings-animated-pages> 294 </settings-animated-pages>
293 <template is="dom-if" if="[[showAddLanguagesDialog_]]" restamp> 295 <template is="dom-if" if="[[showAddLanguagesDialog_]]" restamp>
294 <settings-add-languages-dialog languages="{{languages}}" 296 <settings-add-languages-dialog languages="{{languages}}"
295 language-helper="[[languageHelper]]"> 297 language-helper="[[languageHelper]]">
296 </settings-add-languages-dialog> 298 </settings-add-languages-dialog>
297 </template> 299 </template>
298 </template> 300 </template>
299 <script src="languages_page.js"></script> 301 <script src="languages_page.js"></script>
300 </dom-module> 302 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/settings/languages_page/languages_page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698