Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2683583006: [NTPTiles::Cleanup] Fix unused variable. (Closed)

Created:
3 years, 10 months ago by vitaliii
Modified:
3 years, 10 months ago
Reviewers:
sfiera
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTPTiles::Cleanup] Fix unused variable. I have run a built-in static analyser as an experiment. This CL fixes one positive warning - assinging unused value to a variable. For all presumably false-positive warnings and the setup please see the bug. BUG=689563 Review-Url: https://codereview.chromium.org/2683583006 Cr-Commit-Position: refs/heads/master@{#448949} Committed: https://chromium.googlesource.com/chromium/src/+/875bfeec39358c5e958afc3717159dcd91fdbe4a

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M components/ntp_tiles/most_visited_sites.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
vitaliii
PTAL.
3 years, 10 months ago (2017-02-08 09:52:41 UTC) #3
sfiera
LGTM
3 years, 10 months ago (2017-02-08 09:57:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683583006/20001
3 years, 10 months ago (2017-02-08 10:04:46 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 10:55:30 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/875bfeec39358c5e958afc371715...

Powered by Google App Engine
This is Rietveld 408576698