Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2683553003: [NTP::Downloads] Consider recently visited offline pages not outdated. (Closed)

Created:
3 years, 10 months ago by vitaliii
Modified:
3 years, 10 months ago
Reviewers:
jkrcal
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP::Downloads] Consider recently visited offline pages not outdated. Take into account last_access_time of offline page downloads. Consider offline page downloads which were visited recently (not more than threshold before) not outdated and show them. Reason: if you visit an old download, it is probably interesting to you, even though old. BUG=687888 Review-Url: https://codereview.chromium.org/2683553003 Cr-Commit-Position: refs/heads/master@{#448613} Committed: https://chromium.googlesource.com/chromium/src/+/c02cd260268b3d459a188308a1f70a5bd6a048f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -40 lines) Patch
M chrome/browser/ntp_snippets/download_suggestions_provider.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ntp_snippets/download_suggestions_provider.cc View 3 chunks +13 lines, -6 lines 0 comments Download
M chrome/browser/ntp_snippets/download_suggestions_provider_unittest.cc View 5 chunks +79 lines, -31 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
vitaliii
Hi jkrcal@, PTAL.
3 years, 10 months ago (2017-02-07 12:52:38 UTC) #2
jkrcal
lgtm
3 years, 10 months ago (2017-02-07 13:52:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683553003/1
3 years, 10 months ago (2017-02-07 13:53:32 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 13:58:27 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c02cd260268b3d459a188308a1f7...

Powered by Google App Engine
This is Rietveld 408576698