third_party/WebKit/Source/core/layout/LayoutText.cpp - Issue 2683553002: Fix not autosizing ruby elements issue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutText.cpp

Issue 2683553002: Fix not autosizing ruby elements issue. (Closed)

Patch Set: 1. fix the dcheck fire when sreen ratated and add test case 2. format TextAutosizerTest Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutText.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutText.cpp b/third_party/WebKit/Source/core/layout/LayoutText.cpp

index c79928f7f8e13723c215949a74acc73cea2907f8..a0074fd7ac4d7e296f13f1af1f69635125480aa1 100644

--- a/third_party/WebKit/Source/core/layout/LayoutText.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutText.cpp

@@ -1388,7 +1388,7 @@ void LayoutText::computePreferredLogicalWidths(

fontData->getFontMetrics().floatDescent(), m_maxWidth);

}

// We shouldn't change our mind once we "know".

- ASSERT(!m_knownToHaveNoOverflowAndNoFallbackFonts ||

+ DCHECK(!m_knownToHaveNoOverflowAndNoFallbackFonts ||

skobes 2017/02/16 02:48:37 If you're changing this to DCHECK can you also cha

cathiechentx 2017/02/16 03:17:55 I'd like to roll it back to ASSERT ;)

(fallbackFonts.isEmpty() && glyphOverflow.isApproximatelyZero()));

m_knownToHaveNoOverflowAndNoFallbackFonts =

fallbackFonts.isEmpty() && glyphOverflow.isApproximatelyZero();