Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutText.cpp

Issue 2683553002: Fix not autosizing ruby elements issue. (Closed)
Patch Set: 1. fix the dcheck fire when sreen ratated and add test case 2. format TextAutosizerTest Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * (C) 1999 Lars Knoll (knoll@kde.org) 2 * (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Dirk Mueller (mueller@kde.org) 3 * (C) 2000 Dirk Mueller (mueller@kde.org)
4 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 4 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
5 * Copyright (C) 2006 Andrew Wellington (proton@wiretapped.net) 5 * Copyright (C) 2006 Andrew Wellington (proton@wiretapped.net)
6 * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com) 6 * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 1370 matching lines...) Expand 10 before | Expand all | Expand 10 after
1381 const SimpleFontData* fontData = f.primaryFont(); 1381 const SimpleFontData* fontData = f.primaryFont();
1382 DCHECK(fontData); 1382 DCHECK(fontData);
1383 1383
1384 GlyphOverflow glyphOverflow; 1384 GlyphOverflow glyphOverflow;
1385 if (fontData) { 1385 if (fontData) {
1386 glyphOverflow.setFromBounds( 1386 glyphOverflow.setFromBounds(
1387 glyphBounds, fontData->getFontMetrics().floatAscent(), 1387 glyphBounds, fontData->getFontMetrics().floatAscent(),
1388 fontData->getFontMetrics().floatDescent(), m_maxWidth); 1388 fontData->getFontMetrics().floatDescent(), m_maxWidth);
1389 } 1389 }
1390 // We shouldn't change our mind once we "know". 1390 // We shouldn't change our mind once we "know".
1391 ASSERT(!m_knownToHaveNoOverflowAndNoFallbackFonts || 1391 DCHECK(!m_knownToHaveNoOverflowAndNoFallbackFonts ||
skobes 2017/02/16 02:48:37 If you're changing this to DCHECK can you also cha
cathiechentx 2017/02/16 03:17:55 I'd like to roll it back to ASSERT ;)
1392 (fallbackFonts.isEmpty() && glyphOverflow.isApproximatelyZero())); 1392 (fallbackFonts.isEmpty() && glyphOverflow.isApproximatelyZero()));
1393 m_knownToHaveNoOverflowAndNoFallbackFonts = 1393 m_knownToHaveNoOverflowAndNoFallbackFonts =
1394 fallbackFonts.isEmpty() && glyphOverflow.isApproximatelyZero(); 1394 fallbackFonts.isEmpty() && glyphOverflow.isApproximatelyZero();
1395 1395
1396 clearPreferredLogicalWidthsDirty(); 1396 clearPreferredLogicalWidthsDirty();
1397 } 1397 }
1398 1398
1399 bool LayoutText::isAllCollapsibleWhitespace() const { 1399 bool LayoutText::isAllCollapsibleWhitespace() const {
1400 unsigned length = textLength(); 1400 unsigned length = textLength();
1401 if (is8Bit()) { 1401 if (is8Bit()) {
(...skipping 607 matching lines...) Expand 10 before | Expand all | Expand 10 after
2009 LayoutRect rect = LayoutRect( 2009 LayoutRect rect = LayoutRect(
2010 IntRect(firstRunX(), firstRunY(), linesBox.width(), linesBox.height())); 2010 IntRect(firstRunX(), firstRunY(), linesBox.width(), linesBox.height()));
2011 LayoutBlock* block = containingBlock(); 2011 LayoutBlock* block = containingBlock();
2012 if (block && hasTextBoxes()) 2012 if (block && hasTextBoxes())
2013 block->adjustChildDebugRect(rect); 2013 block->adjustChildDebugRect(rect);
2014 2014
2015 return rect; 2015 return rect;
2016 } 2016 }
2017 2017
2018 } // namespace blink 2018 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698