Upstream changes to HttpUrlRequest for querying response headers and closing ReadableByteChannel.

Upstream changes to:
- Add HttpUrlRequest callback for querying response headers.
- Always close ReadableByteChannel once an HttpUrlRequest is started.

BUG=354143
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271992

[mmenke, 2014-05-09 16:41:40]

LGTM

https://codereview.chromium.org/268353013/diff/1/components/cronet/android/ja...
File
components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequest.java
(right):

https://codereview.chromium.org/268353013/diff/1/components/cronet/android/ja...
components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequest.java:226:

nit:  Remove extra blank line.

https://codereview.chromium.org/268353013/diff/1/components/cronet/android/or...
File components/cronet/android/org_chromium_net_UrlRequest.cc (right):

https://codereview.chromium.org/268353013/diff/1/components/cronet/android/or...
components/cronet/android/org_chromium_net_UrlRequest.cc:310: if (request ==
NULL) {
I don't think we need two of these.  Probably best to keep the return NULL,
rather than 0.  Or better yet, can we just return "jstring()", both here and
below?  Or should it be jstring(NULL)?

https://codereview.chromium.org/268353013/diff/1/components/cronet/android/ur...
File components/cronet/android/url_request_peer.cc (right):

https://codereview.chromium.org/268353013/diff/1/components/cronet/android/ur...
components/cronet/android/url_request_peer.cc:76: if (url_request_ != NULL) {
Long term, we really should probably get rid of all of these, and just not allow
the request to be NULL.

[mef, 2014-05-09 18:49:15]

thanks!

https://codereview.chromium.org/268353013/diff/1/components/cronet/android/ja...
File
components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequest.java
(right):

https://codereview.chromium.org/268353013/diff/1/components/cronet/android/ja...
components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequest.java:226:

On 2014/05/09 16:41:40, mmenke wrote:
> nit:  Remove extra blank line.

Done.

https://codereview.chromium.org/268353013/diff/1/components/cronet/android/or...
File components/cronet/android/org_chromium_net_UrlRequest.cc (right):

https://codereview.chromium.org/268353013/diff/1/components/cronet/android/or...
components/cronet/android/org_chromium_net_UrlRequest.cc:310: if (request ==
NULL) {
On 2014/05/09 16:41:40, mmenke wrote:
> I don't think we need two of these.  
Good catch, we don't.


> Probably best to keep the return NULL,
> rather than 0.  Or better yet, can we just return "jstring()", both here and
> below?  Or should it be jstring(NULL)?
The jstring is actually a pointer: typedef _jstring *jstring;

Returning NULL seems consistent with GetContentType, but I'm open to adding
static_cast.

https://codereview.chromium.org/268353013/diff/1/components/cronet/android/ur...
File components/cronet/android/url_request_peer.cc (right):

https://codereview.chromium.org/268353013/diff/1/components/cronet/android/ur...
components/cronet/android/url_request_peer.cc:76: if (url_request_ != NULL) {
On 2014/05/09 16:41:40, mmenke wrote:
> Long term, we really should probably get rid of all of these, and just not
allow
> the request to be NULL.

sgtm

[mef, 2014-05-19 16:51:31]

ping

[tonycuadra, 2014-05-19 17:32:24]

https://codereview.chromium.org/268353013/diff/20001/components/cronet/androi...
File
components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequest.java
(right):

https://codereview.chromium.org/268353013/diff/20001/components/cronet/androi...
components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequest.java:442:
throw new IllegalStateException("Response headers not  available");
extra space after "header not"

[mef, 2014-05-20 18:04:34]

Thanks, Tony!

https://codereview.chromium.org/268353013/diff/20001/components/cronet/androi...
File
components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequest.java
(right):

https://codereview.chromium.org/268353013/diff/20001/components/cronet/androi...
components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequest.java:442:
throw new IllegalStateException("Response headers not  available");
On 2014/05/19 17:32:24, tonycuadra wrote:
> extra space after "header not"

Done.

[mef, 2014-05-20 22:19:52]

The CQ bit was checked by mef@chromium.org

[commit-bot: I haz the power, 2014-05-20 22:20:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mef@chromium.org/268353013/40001

[commit-bot: I haz the power, 2014-05-21 07:27:18]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-05-21 20:04:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-21 20:04:58]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[mef, 2014-05-21 20:29:05]

The CQ bit was checked by mef@chromium.org

[commit-bot: I haz the power, 2014-05-21 20:30:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mef@chromium.org/268353013/40001

[commit-bot: I haz the power, 2014-05-21 22:36:54]

Change committed as 271992