components/cronet/android/java/src/org/chromium/net/HttpUrlRequestListener.java - Issue 268353013: Upstream changes to HttpUrlRequest for querying response headers and closing ReadableByteChannel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/HttpUrlRequestListener.java

Issue 268353013: Upstream changes to HttpUrlRequest for querying response headers and closing ReadableByteChannel. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comment. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/HttpUrlRequest.java ('k') | components/cronet/android/java/src/org/chromium/net/UrlRequest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/HttpUrlRequestListener.java

diff --git a/components/cronet/android/java/src/org/chromium/net/HttpUrlRequestListener.java b/components/cronet/android/java/src/org/chromium/net/HttpUrlRequestListener.java

index 01e1e829d80a9a10f124b2972347647e00f05406..a922319ae3babdd651117beb905f5c8466ccc766 100644

--- a/components/cronet/android/java/src/org/chromium/net/HttpUrlRequestListener.java

+++ b/components/cronet/android/java/src/org/chromium/net/HttpUrlRequestListener.java

@@ -9,8 +9,10 @@ package org.chromium.net;

public interface HttpUrlRequestListener {

/**

- * A callback invoked when the first chunk of the response has arrived.

- * The listener can only call request getContentType and getContentLength.

+ * A callback invoked when the first chunk of the response has arrived and

+ * response headers have been read. The listener can only call request

+ * getHeader, getContentType and getContentLength. This method will always

+ * be called before {@code onRequestComplete}.

void onResponseStarted(HttpUrlRequest request);