chrome/browser/android/offline_pages/offline_page_utils_unittest.cc - Issue 2683493002: Get signals working in the EXTRA_DATA section of MHTML

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

Issue 2683493002: Get signals working in the EXTRA_DATA section of MHTML (Closed)

Patch Set: FIx tests, add unit test Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc ('k') | chrome/browser/android/offline_pages/prerendering_loader.h » ('j') | content/browser/download/mhtml_generation_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

diff --git a/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc b/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

index 8f55101fdd8e6e87c10824208ee3c7e6061a3278..20d7999d4c39b0cb0a2e7e8749a04f0b52ec1956 100644

--- a/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

+++ b/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

@@ -136,12 +136,12 @@ void OfflinePageUtilsTest::SavePage(

const GURL& url,

const ClientId& client_id,

std::unique_ptr<OfflinePageArchiver> archiver) {

+ std::string signal_data;

OfflinePageModel::SavePageParams save_page_params;

save_page_params.url = url;

save_page_params.client_id = client_id;

OfflinePageModelFactory::GetForBrowserContext(profile())->SavePage(

- save_page_params,

- std::move(archiver),

+ save_page_params, std::move(archiver), signal_data,

base::Bind(&OfflinePageUtilsTest::OnSavePageDone, AsWeakPtr()));

RunUntilIdle();

}