Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc

Issue 2683493002: Get signals working in the EXTRA_DATA section of MHTML (Closed)
Patch Set: FIx tests, add unit test Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc
diff --git a/chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc b/chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc
index 14f6b882c40b9e7805c6d8d3d298c07268cf4124..501acf69f1d7e191e93932b4b57c97261e3d9552 100644
--- a/chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc
+++ b/chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc
@@ -215,6 +215,7 @@ class TestOfflinePageArchiver : public OfflinePageArchiver {
void CreateArchive(const base::FilePath& archives_dir,
const CreateArchiveParams& create_archive_params,
+ const std::string& signal_data,
const CreateArchiveCallback& callback) override {
base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE,
@@ -505,9 +506,11 @@ void OfflinePageRequestJobTest::SavePage(
save_page_params.url = url;
save_page_params.client_id = client_id;
save_page_params.original_url = original_url;
+ std::string extra_data;
OfflinePageModelFactory::GetForBrowserContext(profile())->SavePage(
save_page_params,
std::move(archiver),
+ extra_data,
base::Bind(&OfflinePageRequestJobTest::OnSavePageDone,
base::Unretained(this)));
RunUntilIdle();

Powered by Google App Engine
This is Rietveld 408576698