chrome/browser/android/offline_pages/offline_page_bridge.cc - Issue 2683493002: Get signals working in the EXTRA_DATA section of MHTML

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/offline_page_bridge.cc

Issue 2683493002: Get signals working in the EXTRA_DATA section of MHTML (Closed)

Patch Set: Approach for writing to the file afterwards instead. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/offline_pages/offline_page_bridge.cc

diff --git a/chrome/browser/android/offline_pages/offline_page_bridge.cc b/chrome/browser/android/offline_pages/offline_page_bridge.cc

index 2661b852181505c30741a3229c6ffd8d9c8515f9..09a1f92e81498f9e20fa760d850a5471338b61b3 100644

--- a/chrome/browser/android/offline_pages/offline_page_bridge.cc

+++ b/chrome/browser/android/offline_pages/offline_page_bridge.cc

@@ -106,7 +106,8 @@ void MultipleOfflinePageItemCallback(

void SavePageCallback(const ScopedJavaGlobalRef<jobject>& j_callback_obj,

const GURL& url,

OfflinePageModel::SavePageResult result,

- int64_t offline_id) {

+ int64_t offline_id,

+ const base::FilePath& saved_filepath) {

JNIEnv* env = base::android::AttachCurrentThread();

Java_SavePageCallback_onSavePageDone(