chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc - Issue 2683493002: Get signals working in the EXTRA_DATA section of MHTML

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc

Issue 2683493002: Get signals working in the EXTRA_DATA section of MHTML (Closed)

Patch Set: Approach for writing to the file afterwards instead. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/background_loader_offliner.cc ('k') | chrome/browser/android/offline_pages/offline_page_bridge.cc » ('j') | chrome/browser/android/offline_pages/prerendering_loader.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc

diff --git a/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc b/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc

index b526e2160c67a21ee8c2c875e8504b88050a04a5..c379ef259cf2da5bd95e570953c4a9ac7aa96049 100644

--- a/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc

+++ b/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc

@@ -52,16 +52,17 @@ class MockOfflinePageModel : public StubOfflinePageModel {

DCHECK(mock_saving_);

mock_saving_ = false;

base::ThreadTaskRunnerHandle::Get()->PostTask(

- FROM_HERE, base::Bind(save_page_callback_,

- SavePageResult::ARCHIVE_CREATION_FAILED, 0));

+ FROM_HERE,

+ base::Bind(save_page_callback_, SavePageResult::ARCHIVE_CREATION_FAILED,

+ 0, base::FilePath()));

}

void CompleteSavingAsSuccess() {

DCHECK(mock_saving_);

mock_saving_ = false;

base::ThreadTaskRunnerHandle::Get()->PostTask(

- FROM_HERE,

- base::Bind(save_page_callback_, SavePageResult::SUCCESS, 123456));

+ FROM_HERE, base::Bind(save_page_callback_, SavePageResult::SUCCESS,

+ 123456, base::FilePath()));

}

bool mock_saving() const { return mock_saving_; }