Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: chrome/browser/android/offline_pages/prerendering_loader.h

Issue 2683493002: Get signals working in the EXTRA_DATA section of MHTML (Closed)
Patch Set: Add Arbitrary extra data sections to MHTML. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/prerendering_loader.h
diff --git a/chrome/browser/android/offline_pages/prerendering_loader.h b/chrome/browser/android/offline_pages/prerendering_loader.h
index 7e45fef375163996eddbae437e53c3363f45719d..5e3da90f8efcef30271e633dc4ea4d452808211d 100644
--- a/chrome/browser/android/offline_pages/prerendering_loader.h
+++ b/chrome/browser/android/offline_pages/prerendering_loader.h
@@ -6,6 +6,8 @@
#define CHROME_BROWSER_ANDROID_OFFLINE_PAGES_PRERENDERING_LOADER_H_
#include <memory>
+#include <string>
+#include <vector>
#include "base/callback.h"
#include "chrome/browser/android/offline_pages/prerender_adapter.h"
@@ -82,6 +84,10 @@ class PrerenderingLoader : public PrerenderAdapter::Observer,
// Returns true if the lowbar of snapshotting a page is met.
virtual bool IsLowbarMet();
+ const std::vector<std::string>& GetLoadingSignalData() {
Dmitry Titov 2017/03/18 00:58:33 do you need it as public?
Pete Williamson 2017/03/20 18:26:53 Done.
Pete Williamson 2017/03/20 20:46:44 Oops, this did need to be public, the prerendering
+ return signal_data_;
+ }
+
private:
// State of the loader (only one request may be active at a time).
enum class State {
@@ -120,6 +126,9 @@ class PrerenderingLoader : public PrerenderAdapter::Observer,
// storage namespace for rendering. This will NOT have the loaded page.
std::unique_ptr<content::WebContents> session_contents_;
+ // Signal data collected for this rendering attempt
+ std::vector<std::string> signal_data_;
+
// Callback to call when the active load request completes, fails, or is
// canceled.
LoadPageCallback load_done_callback_;

Powered by Google App Engine
This is Rietveld 408576698