Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Side by Side Diff: chrome/browser/android/offline_pages/prerendering_loader.h

Issue 2683493002: Get signals working in the EXTRA_DATA section of MHTML (Closed)
Patch Set: Add Arbitrary extra data sections to MHTML. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_OFFLINE_PAGES_PRERENDERING_LOADER_H_ 5 #ifndef CHROME_BROWSER_ANDROID_OFFLINE_PAGES_PRERENDERING_LOADER_H_
6 #define CHROME_BROWSER_ANDROID_OFFLINE_PAGES_PRERENDERING_LOADER_H_ 6 #define CHROME_BROWSER_ANDROID_OFFLINE_PAGES_PRERENDERING_LOADER_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string>
10 #include <vector>
9 11
10 #include "base/callback.h" 12 #include "base/callback.h"
11 #include "chrome/browser/android/offline_pages/prerender_adapter.h" 13 #include "chrome/browser/android/offline_pages/prerender_adapter.h"
12 #include "components/offline_pages/core/background/offliner.h" 14 #include "components/offline_pages/core/background/offliner.h"
13 #include "components/offline_pages/core/snapshot_controller.h" 15 #include "components/offline_pages/core/snapshot_controller.h"
14 16
15 class GURL; 17 class GURL;
16 18
17 namespace content { 19 namespace content {
18 class BrowserContext; 20 class BrowserContext;
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 void OnPrerenderDomContentLoaded() override; 77 void OnPrerenderDomContentLoaded() override;
76 void OnPrerenderStop() override; 78 void OnPrerenderStop() override;
77 void OnPrerenderNetworkBytesChanged(int64_t bytes) override; 79 void OnPrerenderNetworkBytesChanged(int64_t bytes) override;
78 80
79 // SnapshotController::Client implementation: 81 // SnapshotController::Client implementation:
80 void StartSnapshot() override; 82 void StartSnapshot() override;
81 83
82 // Returns true if the lowbar of snapshotting a page is met. 84 // Returns true if the lowbar of snapshotting a page is met.
83 virtual bool IsLowbarMet(); 85 virtual bool IsLowbarMet();
84 86
87 const std::vector<std::string>& GetLoadingSignalData() {
Dmitry Titov 2017/03/18 00:58:33 do you need it as public?
Pete Williamson 2017/03/20 18:26:53 Done.
Pete Williamson 2017/03/20 20:46:44 Oops, this did need to be public, the prerendering
88 return signal_data_;
89 }
90
85 private: 91 private:
86 // State of the loader (only one request may be active at a time). 92 // State of the loader (only one request may be active at a time).
87 enum class State { 93 enum class State {
88 IDLE, // No active load request. 94 IDLE, // No active load request.
89 PENDING, // Load request is pending the start of prerendering. 95 PENDING, // Load request is pending the start of prerendering.
90 LOADING, // Loading in progress. 96 LOADING, // Loading in progress.
91 LOADED, // Loaded and now waiting for requestor to StopLoading(). 97 LOADED, // Loaded and now waiting for requestor to StopLoading().
92 }; 98 };
93 99
94 // Handles some event/signal that the load request has succeeded or failed. 100 // Handles some event/signal that the load request has succeeded or failed.
(...skipping 18 matching lines...) Expand all
113 // Not owned. 119 // Not owned.
114 content::BrowserContext* browser_context_; 120 content::BrowserContext* browser_context_;
115 121
116 // Adapter for handling calls to the prerender stack. 122 // Adapter for handling calls to the prerender stack.
117 std::unique_ptr<PrerenderAdapter> adapter_; 123 std::unique_ptr<PrerenderAdapter> adapter_;
118 124
119 // A WebContents for the active load request that is used to hold the session 125 // A WebContents for the active load request that is used to hold the session
120 // storage namespace for rendering. This will NOT have the loaded page. 126 // storage namespace for rendering. This will NOT have the loaded page.
121 std::unique_ptr<content::WebContents> session_contents_; 127 std::unique_ptr<content::WebContents> session_contents_;
122 128
129 // Signal data collected for this rendering attempt
130 std::vector<std::string> signal_data_;
131
123 // Callback to call when the active load request completes, fails, or is 132 // Callback to call when the active load request completes, fails, or is
124 // canceled. 133 // canceled.
125 LoadPageCallback load_done_callback_; 134 LoadPageCallback load_done_callback_;
126 135
127 // Callback to call when we know more bytes have loaded from the network. 136 // Callback to call when we know more bytes have loaded from the network.
128 ProgressCallback progress_callback_; 137 ProgressCallback progress_callback_;
129 138
130 // True if the lowbar of snapshotting a page is met. 139 // True if the lowbar of snapshotting a page is met.
131 bool is_lowbar_met_; 140 bool is_lowbar_met_;
132 141
133 DISALLOW_COPY_AND_ASSIGN(PrerenderingLoader); 142 DISALLOW_COPY_AND_ASSIGN(PrerenderingLoader);
134 }; 143 };
135 144
136 } // namespace offline_pages 145 } // namespace offline_pages
137 146
138 #endif // CHROME_BROWSER_ANDROID_OFFLINE_PAGES_PRERENDERING_LOADER_H_ 147 #endif // CHROME_BROWSER_ANDROID_OFFLINE_PAGES_PRERENDERING_LOADER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698