Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Unified Diff: components/offline_pages/core/offline_page_model_impl.cc

Issue 2683493002: Get signals working in the EXTRA_DATA section of MHTML (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/core/offline_page_model_impl.cc
diff --git a/components/offline_pages/core/offline_page_model_impl.cc b/components/offline_pages/core/offline_page_model_impl.cc
index 8c20f6909268c83122127db4efeb76549695aa46..fc24c15c4d40af9704c3e888ffb886f8d339f057 100644
--- a/components/offline_pages/core/offline_page_model_impl.cc
+++ b/components/offline_pages/core/offline_page_model_impl.cc
@@ -338,6 +338,7 @@ void OfflinePageModelImpl::RemoveObserver(Observer* observer) {
void OfflinePageModelImpl::SavePage(
const SavePageParams& save_page_params,
std::unique_ptr<OfflinePageArchiver> archiver,
+ const std::vector<std::string>& signal_data,
const SavePageCallback& callback) {
DCHECK(is_loaded_);
@@ -366,7 +367,7 @@ void OfflinePageModelImpl::SavePage(
// popup overlay that obstructs viewing the normal content.
create_archive_params.remove_popup_overlay = save_page_params.is_background;
archiver->CreateArchive(
- archives_dir_, create_archive_params,
+ archives_dir_, create_archive_params, signal_data,
base::Bind(&OfflinePageModelImpl::OnCreateArchiveDone,
weak_ptr_factory_.GetWeakPtr(), save_page_params, offline_id,
GetCurrentTime(), callback));

Powered by Google App Engine
This is Rietveld 408576698