Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1861)

Unified Diff: chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h

Issue 2683493002: Get signals working in the EXTRA_DATA section of MHTML (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h
diff --git a/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h b/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h
index 59272ad5ec4d1d20f5626c21a10d22d61271465a..a35b401964821e115271116420603537f5b8200f 100644
--- a/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h
+++ b/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h
@@ -9,6 +9,7 @@
#include <map>
#include <string>
+#include <vector>
#include "base/callback.h"
#include "base/macros.h"
@@ -49,6 +50,7 @@ class OfflinePageMHTMLArchiver : public OfflinePageArchiver {
// OfflinePageArchiver implementation:
void CreateArchive(const base::FilePath& archives_dir,
const CreateArchiveParams& create_archive_params,
+ const std::vector<std::string>& signal_data,
const CreateArchiveCallback& callback) override;
protected:
@@ -78,6 +80,11 @@ class OfflinePageMHTMLArchiver : public OfflinePageArchiver {
// Contents of the web page to be serialized. Not owned.
content::WebContents* web_contents_;
+ // Saved signal data corresponding to this page load. This is a way of logging
+ // signals that have been received as of the time of the page capture to help
+ // training a recognizer for when to take a snapshot.
fgorski 2017/02/07 22:06:07 s/training a recognizer/improving a component/
+ std::vector<std::string> signal_data_;
+
CreateArchiveCallback callback_;
base::WeakPtrFactory<OfflinePageMHTMLArchiver> weak_ptr_factory_;

Powered by Google App Engine
This is Rietveld 408576698