Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 2683393003: Refactor TabModel to use WebStateList to store WebStates. (Closed)

Created:
3 years, 10 months ago by sdefresne
Modified:
3 years, 9 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor TabModel to use WebStateList to store WebStates. Refactor TabModel to use WebStateList to store WebStates to share code with the new architecture. Keep a NSSet<Tab*> to retain the Tabs (as TabModel owns them and WebStateList cannot). BUG=687207 Review-Url: https://codereview.chromium.org/2683393003 Cr-Commit-Position: refs/heads/master@{#451319} Committed: https://chromium.googlesource.com/chromium/src/+/32c0c38623575d0441969a8a11b23ee540bf28cb

Patch Set 1 #

Patch Set 2 : Rebase to get dependent CL fix of "gn check". #

Total comments: 6

Patch Set 3 : Rebase with WebStateList API using int and address comments. #

Patch Set 4 : Rebase. #

Patch Set 5 : Fix TabModelTest.MoveTabs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -64 lines) Patch
M ios/chrome/browser/tabs/BUILD.gn View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/tabs/tab_model.mm View 1 2 3 4 27 chunks +127 lines, -63 lines 0 comments Download
M ios/chrome/browser/tabs/tab_model_order_controller_unittest.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 32 (23 generated)
sdefresne
Please take a look.
3 years, 10 months ago (2017-02-10 16:13:09 UTC) #3
marq (ping after 24h)
lgtm
3 years, 10 months ago (2017-02-13 16:36:57 UTC) #11
rohitrao (ping after 24h)
lgtm https://codereview.chromium.org/2683393003/diff/20001/ios/chrome/browser/tabs/tab_model.mm File ios/chrome/browser/tabs/tab_model.mm (right): https://codereview.chromium.org/2683393003/diff/20001/ios/chrome/browser/tabs/tab_model.mm#newcode127 ios/chrome/browser/tabs/tab_model.mm:127: // in the WebStateList (as Tabs currently owns ...
3 years, 10 months ago (2017-02-14 14:37:12 UTC) #12
sdefresne
PTAL. https://codereview.chromium.org/2683393003/diff/20001/ios/chrome/browser/tabs/tab_model.mm File ios/chrome/browser/tabs/tab_model.mm (right): https://codereview.chromium.org/2683393003/diff/20001/ios/chrome/browser/tabs/tab_model.mm#newcode127 ios/chrome/browser/tabs/tab_model.mm:127: // in the WebStateList (as Tabs currently owns ...
3 years, 10 months ago (2017-02-14 16:45:46 UTC) #15
rohitrao (ping after 24h)
lgtm
3 years, 10 months ago (2017-02-14 18:04:40 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683393003/80001
3 years, 10 months ago (2017-02-17 13:05:33 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/384928)
3 years, 10 months ago (2017-02-17 14:20:07 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683393003/80001
3 years, 10 months ago (2017-02-17 15:33:37 UTC) #29
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 16:38:25 UTC) #32
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/32c0c38623575d0441969a8a11b2...

Powered by Google App Engine
This is Rietveld 408576698