Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2683393002: [iOS Reading List] Skip invalid images in distillation. (Closed)

Created:
3 years, 10 months ago by Olivier
Modified:
3 years, 10 months ago
Reviewers:
gambard
CC:
chromium-reviews, marq+watch_chromium.org, stkhapugin, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS Reading List] Skip invalid images in distillation. If an image is invalid (e.g. src pointing to not existing URL), the current behavior is to fail the whole distillation. Just skip the image instead (as normal rendering would do). Replace src by empty string to avoid network acces when displaying offline page. BUG=690829 Review-Url: https://codereview.chromium.org/2683393002 Cr-Commit-Position: refs/heads/master@{#449577} Committed: https://chromium.googlesource.com/chromium/src/+/182bfc3b6cd2c7536577752dfbf032e42207b34f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M ios/chrome/browser/reading_list/url_downloader.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Olivier
3 years, 10 months ago (2017-02-10 10:12:32 UTC) #2
gambard
lgtm
3 years, 10 months ago (2017-02-10 10:15:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683393002/1
3 years, 10 months ago (2017-02-10 10:16:33 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 10:27:08 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/182bfc3b6cd2c7536577752dfbf0...

Powered by Google App Engine
This is Rietveld 408576698