Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Unified Diff: chrome/browser/ntp_snippets/download_suggestions_provider_unittest.cc

Issue 2683383002: [NTP:Downloads] Request offline pages even if model is not loaded. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ntp_snippets/download_suggestions_provider_unittest.cc
diff --git a/chrome/browser/ntp_snippets/download_suggestions_provider_unittest.cc b/chrome/browser/ntp_snippets/download_suggestions_provider_unittest.cc
index ad9a326b0069f99546209240932c25956701c732..932098de3b5447c11c99ec04fc6a34310a90d7bb 100644
--- a/chrome/browser/ntp_snippets/download_suggestions_provider_unittest.cc
+++ b/chrome/browser/ntp_snippets/download_suggestions_provider_unittest.cc
@@ -856,7 +856,6 @@ TEST_F(DownloadSuggestionsProviderTest,
IgnoreOnCategoryStatusChangedToAvailable();
*(offline_pages_model()->mutable_items()) = CreateDummyOfflinePages({1, 2});
- offline_pages_model()->set_is_loaded(true);
Marc Treib 2017/02/10 09:08:11 I guess this just isn't required anymore; it would
vitaliii 2017/02/10 09:39:56 No, it wouldn't. Anyway is_loaded = true by defaul
Marc Treib 2017/02/10 10:05:02 Acknowledged.
EXPECT_CALL(*observer(), OnNewSuggestions(_, downloads_category(),
UnorderedElementsAre(
HasUrl("http://dummy.com/1"),
@@ -964,7 +963,6 @@ TEST_F(DownloadSuggestionsProviderTest,
IgnoreOnSuggestionInvalidated();
*(offline_pages_model()->mutable_items()) = CreateDummyOfflinePages({1, 2});
- offline_pages_model()->set_is_loaded(true);
EXPECT_CALL(*observer(), OnNewSuggestions(_, downloads_category(),
UnorderedElementsAre(
HasUrl("http://dummy.com/1"),

Powered by Google App Engine
This is Rietveld 408576698