[NTP:Downloads] Request offline pages even if model is not loaded.

chrome/browser/ntp_snippets/download_suggestions_provider_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ntp_snippets/download_suggestions_provider.h"
 
 #include <memory>
 
 #include "base/bind.h"
 #include "base/memory/ptr_util.h"
@@ skipping 838 matching lines @@
                                             HasUrl("http://download.com/2"))));
   CreateLoadedProvider(/*show_assets=*/true, /*show_offline_pages=*/true,
                        base::MakeUnique<base::DefaultClock>());
 }
 
 TEST_F(DownloadSuggestionsProviderTest,
        ShouldFetchOfflinePageDownloadsOnStartup) {
   IgnoreOnCategoryStatusChangedToAvailable();
 
   *(offline_pages_model()->mutable_items()) = CreateDummyOfflinePages({1, 2});
-  offline_pages_model()->set_is_loaded(true);

[Marc Treib, 2017/02/10 09:08:11]

I guess this just isn't required anymore; it wouldn't hurt to keep it there?

[vitaliii, 2017/02/10 09:39:56]

No, it wouldn't.
Anyway is_loaded = true by default, so that line had no effect except making
this explicit to the reader. Since we do not use it in our code, I though that
there is no point to notify the reader about it. 
Also dewittj@ was going to make is_loaded private in
https://codereview.chromium.org/2564163002/.

[Marc Treib, 2017/02/10 10:05:02]

Acknowledged.

   EXPECT_CALL(*observer(), OnNewSuggestions(_, downloads_category(),
                                             UnorderedElementsAre(
                                                 HasUrl("http://dummy.com/1"),
                                                 HasUrl("http://dummy.com/2"))));
   CreateProvider(/*show_assets=*/false, /*show_offline_pages=*/true,
                  base::MakeUnique<base::DefaultClock>());
   FireOfflinePageModelLoaded();
 }
 
 TEST_F(DownloadSuggestionsProviderTest,
@@ skipping 87 matching lines @@
   CreateLoadedProvider(/*show_assets=*/true, /*show_offline_pages=*/false,
                        base::MakeUnique<base::DefaultClock>());
 }
 
 TEST_F(DownloadSuggestionsProviderTest,
        ShouldLoadAndSubmitOfflinePagesEvenIfAssetDownloadsAreTurnedOff) {
   IgnoreOnCategoryStatusChangedToAvailable();
   IgnoreOnSuggestionInvalidated();
 
   *(offline_pages_model()->mutable_items()) = CreateDummyOfflinePages({1, 2});
-  offline_pages_model()->set_is_loaded(true);
   EXPECT_CALL(*observer(), OnNewSuggestions(_, downloads_category(),
                                             UnorderedElementsAre(
                                                 HasUrl("http://dummy.com/1"),
                                                 HasUrl("http://dummy.com/2"))));
   CreateProvider(/*show_assets=*/false, /*show_offline_pages=*/true,
                  base::MakeUnique<base::DefaultClock>());
 }
 
 TEST_F(DownloadSuggestionsProviderTest, ShouldStoreDismissedSuggestions) {
   IgnoreOnCategoryStatusChangedToAvailable();
@@ skipping 131 matching lines @@
   // it has been visited recently.
   EXPECT_CALL(
       *observer(),
       OnNewSuggestions(_, downloads_category(),
                        UnorderedElementsAre(HasUrl("http://dummy.com/0"))));
   auto test_clock = base::MakeUnique<base::SimpleTestClock>();
   test_clock->SetNow(now);
   CreateProvider(/*show_assets=*/false, /*show_offline_pages=*/true,
                  std::move(test_clock));
 }