Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2683373002: Remove a redundant template from PagePool (Closed)

Created:
3 years, 10 months ago by haraken
Modified:
3 years, 10 months ago
Reviewers:
sof
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), haraken, blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove a redundant template from PagePool PagePool is now only inherited by FreePagePool. We can merge the two classes into two. BUG=671856 Review-Url: https://codereview.chromium.org/2683373002 Cr-Commit-Position: refs/heads/master@{#449569} Committed: https://chromium.googlesource.com/chromium/src/+/24fb545f63481edd2641209393094bcc8811cd85

Patch Set 1 #

Patch Set 2 : temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -36 lines) Patch
M third_party/WebKit/Source/platform/heap/Heap.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.cpp View 1 3 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/PagePool.h View 1 1 chunk +16 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/PagePool.cpp View 3 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
haraken
PTAL
3 years, 10 months ago (2017-02-10 07:36:13 UTC) #2
sof
lgtm
3 years, 10 months ago (2017-02-10 07:38:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683373002/20001
3 years, 10 months ago (2017-02-10 07:39:23 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 09:17:22 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/24fb545f63481edd264120939309...

Powered by Google App Engine
This is Rietveld 408576698