Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2683333002: Add detailed use-counter stats for the prefixed quota APIs (Closed)

Created:
3 years, 10 months ago by jsbell
Modified:
3 years, 10 months ago
Reviewers:
Mark P, foolip
CC:
chromium-reviews, blink-reviews, haraken, kinuko+fileapi, nhiroki, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add detailed use-counter stats for the prefixed quota APIs The "legacy" prefixed quota APIs have ridiculously high usage counts: The oldest one window.webkitStorageInfo tracked as PrefixedStorageInfo has 0.07% of page loads which is crazy high... But navigator.webkitTemporaryStorage/webkitTemporaryStorage tracked together as as PrefixedStorageQuota have 0.8% of page loads! The counters exist on the attributes gating access, rather than the methods themselves, so they might be getting overcounted due to simple enumeration of the window/navigator objects. This change adds per-method counters that will show actual usage of the APIs so we can better plan out a deprecation strategy. BUG=689601 R=mpearson@chromium.org,foolip@chromium.org Review-Url: https://codereview.chromium.org/2683333002 Cr-Commit-Position: refs/heads/master@{#449685} Committed: https://chromium.googlesource.com/chromium/src/+/b2d99c3aed47c0f159676a1fbf496e530be25885

Patch Set 1 #

Patch Set 2 : Fix enums #

Patch Set 3 : tool fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/DeprecatedStorageInfo.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/DeprecatedStorageQuota.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/update_use_counter_feature_enum.py View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
jsbell
mpearson@ - can you review the histograms changes and tool fix? foolip@ - can you ...
3 years, 10 months ago (2017-02-10 01:37:52 UTC) #4
foolip
lgtm
3 years, 10 months ago (2017-02-10 04:24:19 UTC) #6
Mark P
metrics/ lgtm
3 years, 10 months ago (2017-02-10 05:15:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683333002/40001
3 years, 10 months ago (2017-02-10 17:25:55 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 19:26:30 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b2d99c3aed47c0f159676a1fbf49...

Powered by Google App Engine
This is Rietveld 408576698