Add "Search" key press/hold UMA metrics.

Add "Search" key press/hold UMA metrics.

Record the time between the search button being pressed and a
second key being pressed down to activate a shortcut.

BUG=688615
TEST=manually on a device and locally.

Review-Url: https://codereview.chromium.org/2683233008
Cr-Commit-Position: refs/heads/master@{#451018}
Committed: https://chromium.googlesource.com/chromium/src/+/71fcc2bfa4b36ce4085ac5f0346b1cdc86b98f5d

[xc, 2017-02-10 23:59:39]

Description was changed from

==========
Add "Search" key press/hold UMA metrics.

Record the time between the search button being pressed and a
second key being pressed down to activate a shortcut.

BUG=688615
TEST=manually on a device and locally.
==========

to

==========
Add "Search" key press/hold UMA metrics.

Record the time between the search button being pressed and a
second key being pressed down to activate a shortcut.

BUG=688615
TEST=manually on a device and locally.
==========

[xc, 2017-02-10 23:59:39]

xiaohuic@chromium.org changed reviewers:
+ xiyuan@chromium.org

[xiyuan, 2017-02-13 22:52:30]

lgtm

I am not ash owner. You need an owner to review as well.

[xc, 2017-02-13 23:12:02]

xiaohuic@chromium.org changed reviewers:
+ oshima@chromium.org

[oshima, 2017-02-14 05:10:57]

https://codereview.chromium.org/2683233008/diff/20001/ash/common/accelerators...
File ash/common/accelerators/accelerator_router.h (right):

https://codereview.chromium.org/2683233008/diff/20001/ash/common/accelerators...
ash/common/accelerators/accelerator_router.h:50: bool
search_key_pressed_recorded_ = false;
instead of having two variable, can you use state enum like

NONE -> PRESSED -> RECORDED -> NONE

[xc, 2017-02-15 21:22:56]

updated with enum

[oshima, 2017-02-15 22:44:20]

lgtm thanks!

[xc, 2017-02-15 23:42:29]

xiaohuic@chromium.org changed reviewers:
+ isherman@chromium.org

[xc, 2017-02-15 23:43:12]

Add Ilya for histogram review.

[Ilya Sherman, 2017-02-15 23:47:50]

Metrics LGTM

[xc, 2017-02-16 17:18:32]

The CQ bit was checked by xiaohuic@chromium.org

[xc, 2017-02-16 17:18:33]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2683233008/#ps40001
(title: "use enum")

[commit-bot: I haz the power, 2017-02-16 17:19:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 18:37:07]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487265512464070,
"parent_rev": "18d3d642ea025592538cfa47f4feb1f814460d7e", "commit_rev":
"71fcc2bfa4b36ce4085ac5f0346b1cdc86b98f5d"}

[commit-bot: I haz the power, 2017-02-16 18:37:44]

Description was changed from

==========
Add "Search" key press/hold UMA metrics.

Record the time between the search button being pressed and a
second key being pressed down to activate a shortcut.

BUG=688615
TEST=manually on a device and locally.
==========

to

==========
Add "Search" key press/hold UMA metrics.

Record the time between the search button being pressed and a
second key being pressed down to activate a shortcut.

BUG=688615
TEST=manually on a device and locally.

Review-Url: https://codereview.chromium.org/2683233008
Cr-Commit-Position: refs/heads/master@{#451018}
Committed:
https://chromium.googlesource.com/chromium/src/+/71fcc2bfa4b36ce4085ac5f0346b...
==========

[commit-bot: I haz the power, 2017-02-16 18:37:45]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/71fcc2bfa4b36ce4085ac5f0346b...