[sync] Call ConsumeCachedPassphraseIfPossible after SetSyncEngine

[sync] Call ConsumeCachedPassphraseIfPossible after SetSyncEngine

ConsumeCachedPassphrase returns early without a sync engine. Set the
engine before asking to consume the passphrase so that the passphrase
will actually be cleared when we expect it to be.

R=skym@chromium.org

BUG=690669
Review-Url: https://codereview.chromium.org/2683203003
Cr-Commit-Position: refs/heads/master@{#449649}
Committed: https://chromium.googlesource.com/chromium/src/+/202a5a81ed0c0929c55d28e44b822f5bbc194ade

[Patrick Noland, 2017-02-10 01:02:33]

The CQ bit was checked by pnoland@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 01:03:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 02:13:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 02:13:34]

Dry run: This issue passed the CQ dry run.

[skym, 2017-02-10 16:55:19]

I don't want to delay getting this fix checked in, but can you follow up with an
integ or unit test that hits without your fix?

lgtm

[Patrick Noland, 2017-02-10 17:41:27]

The CQ bit was checked by pnoland@chromium.org

[commit-bot: I haz the power, 2017-02-10 17:42:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 17:47:40]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486748487958420, "parent_rev":
"50d051af8f403145ab9223b98118f67c6a2a5259", "commit_rev":
"202a5a81ed0c0929c55d28e44b822f5bbc194ade"}

[commit-bot: I haz the power, 2017-02-10 17:48:18]

Description was changed from

==========
[sync] Call ConsumeCachedPassphraseIfPossible after SetSyncEngine

ConsumeCachedPassphrase returns early without a sync engine. Set the
engine before asking to consume the passphrase so that the passphrase
will actually be cleared when we expect it to be.

R=skym@chromium.org

BUG=690669
==========

to

==========
[sync] Call ConsumeCachedPassphraseIfPossible after SetSyncEngine

ConsumeCachedPassphrase returns early without a sync engine. Set the
engine before asking to consume the passphrase so that the passphrase
will actually be cleared when we expect it to be.

R=skym@chromium.org

BUG=690669

Review-Url: https://codereview.chromium.org/2683203003
Cr-Commit-Position: refs/heads/master@{#449649}
Committed:
https://chromium.googlesource.com/chromium/src/+/202a5a81ed0c0929c55d28e44b82...
==========

[commit-bot: I haz the power, 2017-02-10 17:48:20]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/202a5a81ed0c0929c55d28e44b82...