Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2683173002: Rename WindowTreeHostPlatform::window_ to ::platform_window_ (Closed)

Created:
3 years, 10 months ago by tonikitoo
Modified:
3 years, 10 months ago
Reviewers:
sadrul
CC:
chromium-reviews, kalyank, fwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename WindowTreeHostPlatform::window_ to ::platform_window_ Reason for that is that its parent class (WindowTreeHost) also has a 'window_' member of a different type (aura::Window). Driven by CL to make naming clearer to readers. BUG=none Review-Url: https://codereview.chromium.org/2683173002 Cr-Commit-Position: refs/heads/master@{#449418} Committed: https://chromium.googlesource.com/chromium/src/+/49d27c503c29e7a42463c236f6f0a5627d347ef0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M ui/aura/window_tree_host_platform.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/window_tree_host_platform.cc View 4 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
tonikitoo
3 years, 10 months ago (2017-02-09 16:30:52 UTC) #3
sadrul
lgtm (BUG=none or just remove BUG= in the CL description)
3 years, 10 months ago (2017-02-09 21:22:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683173002/1
3 years, 10 months ago (2017-02-09 21:24:41 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 21:37:38 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/49d27c503c29e7a42463c236f6f0...

Powered by Google App Engine
This is Rietveld 408576698