Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2683113003: cc: Ensure that large damage doesn't register as "frame has no damage" (Closed)

Created:
3 years, 10 months ago by vmpstr
Modified:
3 years, 10 months ago
Reviewers:
danakj, enne (OOO)
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

cc: Ensure that large damage doesn't register as "frame has no damage" When we have accumulating damage from really large or really far rects we can't union them correctly. So instead, introduce a DamageAccumulator that detects this and an additional function ShouldDamageEverything that ensures that if we run into this situation, we just damage everything we can. R=danakj@chromium.org, enne@chromium.org BUG=678432, 686873 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2632463005 Cr-Commit-Position: refs/heads/master@{#445208} (cherry picked from commit efb8e7ef70d18b7380210e7244113653ab41cf42) Review-Url: https://codereview.chromium.org/2683113003 . Cr-Commit-Position: refs/branch-heads/2987@{#414} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/4199618e79323f620735b60e833bdc77bca3c77c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+609 lines, -250 lines) Patch
M cc/debug/debug_rect_history.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M cc/layers/render_surface_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/render_surface_impl.cc View 2 chunks +11 lines, -3 lines 0 comments Download
M cc/trees/damage_tracker.h View 3 chunks +51 lines, -12 lines 0 comments Download
M cc/trees/damage_tracker.cc View 12 chunks +97 lines, -58 lines 0 comments Download
M cc/trees/damage_tracker_unittest.cc View 60 chunks +427 lines, -159 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_damage.cc View 5 chunks +15 lines, -10 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_video.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
vmpstr
3 years, 10 months ago (2017-02-09 20:23:35 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4199618e79323f620735b60e833bdc77bca3c77c.

Powered by Google App Engine
This is Rietveld 408576698