[bootstrapper] Remove Intl experimental natives files

[bootstrapper] Remove Intl experimental natives files

These experimental natives previously only installed functions to the
appropriate parent. In this patch, the exports container is retained
so that the bootstrapper may install the functions instead. This
change is intended to reduce startup time. SharedArrayBuffer retains
some experimental natives exported from JS; this may be addressed
in a follow-on patch. The patch includes some minor cleanup of the
bootstrap process by removing "experimental exports", which was unused.

R=yangguo@chromium.org
BUG=v8:5880
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng

Review-Url: https://codereview.chromium.org/2683083003
Cr-Commit-Position: refs/heads/master@{#43221}
Committed: https://chromium.googlesource.com/v8/v8/+/407d6bf16b37636dc2dfd91087a4e2b318ad2399

[Dan Ehrenberg, 2017-02-09 17:54:50]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 17:54:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Ehrenberg, 2017-02-09 17:54:59]

Description was changed from

==========
[bootstrapper] Remove Intl experimental natives files

These experimental natives previously only installed functions to the
appropriate parent. In this patch, the exports container is retained
so that the bootstrapper may install the functions instead. This
change is intended to reduce startup time. SharedArrayBuffer retains
some experimental natives exported from JS; this may be addressed
in a follow-on patch.

R=yangguo@chromium.org
BUG=5880
==========

to

==========
[bootstrapper] Remove Intl experimental natives files

These experimental natives previously only installed functions to the
appropriate parent. In this patch, the exports container is retained
so that the bootstrapper may install the functions instead. This
change is intended to reduce startup time. SharedArrayBuffer retains
some experimental natives exported from JS; this may be addressed
in a follow-on patch.

R=yangguo@chromium.org
BUG=v8:5880
==========

[commit-bot: I haz the power, 2017-02-09 18:16:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 18:16:32]

Dry run: Try jobs failed on following builders:
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/17180)
  v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)

[Dan Ehrenberg, 2017-02-09 18:52:23]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 18:52:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 19:11:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 19:11:48]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[Dan Ehrenberg, 2017-02-10 07:52:37]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 07:52:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Ehrenberg, 2017-02-10 08:03:21]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 08:03:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Ehrenberg, 2017-02-10 08:24:32]

PTAL

[commit-bot: I haz the power, 2017-02-10 08:33:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 08:33:42]

Dry run: This issue passed the CQ dry run.

[Yang, 2017-02-13 14:51:17]

https://codereview.chromium.org/2683083003/diff/40001/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/2683083003/diff/40001/src/bootstrapper.cc#new...
src/bootstrapper.cc:3630: void
Genesis::InitializeGlobal_harmony_array_prototype_values() {
could we install the experimental functions like this?

[Dan Ehrenberg, 2017-02-13 19:18:36]

Description was changed from

==========
[bootstrapper] Remove Intl experimental natives files

These experimental natives previously only installed functions to the
appropriate parent. In this patch, the exports container is retained
so that the bootstrapper may install the functions instead. This
change is intended to reduce startup time. SharedArrayBuffer retains
some experimental natives exported from JS; this may be addressed
in a follow-on patch.

R=yangguo@chromium.org
BUG=v8:5880
==========

to

==========
[bootstrapper] Remove Intl experimental natives files

These experimental natives previously only installed functions to the
appropriate parent. In this patch, the exports container is retained
so that the bootstrapper may install the functions instead. This
change is intended to reduce startup time. SharedArrayBuffer retains
some experimental natives exported from JS; this may be addressed
in a follow-on patch.

R=yangguo@chromium.org
BUG=v8:5880
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng
==========

[Dan Ehrenberg, 2017-02-13 19:19:46]

Description was changed from

==========
[bootstrapper] Remove Intl experimental natives files

These experimental natives previously only installed functions to the
appropriate parent. In this patch, the exports container is retained
so that the bootstrapper may install the functions instead. This
change is intended to reduce startup time. SharedArrayBuffer retains
some experimental natives exported from JS; this may be addressed
in a follow-on patch.

R=yangguo@chromium.org
BUG=v8:5880
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng
==========

to

==========
[bootstrapper] Remove Intl experimental natives files

These experimental natives previously only installed functions to the
appropriate parent. In this patch, the exports container is retained
so that the bootstrapper may install the functions instead. This
change is intended to reduce startup time. SharedArrayBuffer retains
some experimental natives exported from JS; this may be addressed
in a follow-on patch. The patch includes some minor cleanup of the
bootstrap process by removing "experimental exports", which was unused.

R=yangguo@chromium.org
BUG=v8:5880
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng
==========

[Dan Ehrenberg, 2017-02-13 19:20:09]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 19:20:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 19:29:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 19:29:04]

Dry run: Try jobs failed on following builders:
  v8_linux_noi18n_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_noi18n_rel_ng/buil...)

[Dan Ehrenberg, 2017-02-13 19:50:12]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 19:50:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Ehrenberg, 2017-02-13 20:05:43]

https://codereview.chromium.org/2683083003/diff/40001/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/2683083003/diff/40001/src/bootstrapper.cc#new...
src/bootstrapper.cc:3630: void
Genesis::InitializeGlobal_harmony_array_prototype_values() {
On 2017/02/13 14:51:16, Yang wrote:
> could we install the experimental functions like this?

Done.

[commit-bot: I haz the power, 2017-02-13 20:15:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 20:15:04]

Dry run: This issue passed the CQ dry run.

[Yang, 2017-02-15 12:40:15]

LGTM with comments.

https://codereview.chromium.org/2683083003/diff/80001/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/2683083003/diff/80001/src/bootstrapper.cc#new...
src/bootstrapper.cc:3499:
isolate->native_context()->set_exports_container(*container);
Please clear this context field where we clear utils object (at the end of
ConfigureUtilsObject).

https://codereview.chromium.org/2683083003/diff/80001/src/bootstrapper.cc#new...
src/bootstrapper.cc:3678: factory()->InternalizeUtf8String("ToLowerCaseI18N"))
We could also implement these functions as builtins, and simply replace the code
object depending on the flag, similar to
InitializeGlobal_enable_fast_array_builtins.

https://codereview.chromium.org/2683083003/diff/80001/src/bootstrapper.cc#new...
src/bootstrapper.cc:4191: HARMONY_SHIPPING(INSTALL_EXPERIMENTAL_NATIVES);
Can we remove HARMONY_SHIPPING from here, so that in the future, moving a
harmony feature to --harmony-shipping requires it to not tank start-up
performance? Also please add a comment explaining this, here.

https://codereview.chromium.org/2683083003/diff/80001/src/js/prologue.js
File src/js/prologue.js (right):

https://codereview.chromium.org/2683083003/diff/80001/src/js/prologue.js#newc...
src/js/prologue.js:204: function PostExperimentals(utils) {
We should figure out a way to not run this function anymore from the
bootstrapper if no experimental script has run.

[Dan Ehrenberg, 2017-02-15 16:43:27]

https://codereview.chromium.org/2683083003/diff/80001/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/2683083003/diff/80001/src/bootstrapper.cc#new...
src/bootstrapper.cc:3499:
isolate->native_context()->set_exports_container(*container);
On 2017/02/15 12:40:15, Yang wrote:
> Please clear this context field where we clear utils object (at the end of
> ConfigureUtilsObject).

Done.

https://codereview.chromium.org/2683083003/diff/80001/src/bootstrapper.cc#new...
src/bootstrapper.cc:3678: factory()->InternalizeUtf8String("ToLowerCaseI18N"))
On 2017/02/15 12:40:15, Yang wrote:
> We could also implement these functions as builtins, and simply replace the
code
> object depending on the flag, similar to
> InitializeGlobal_enable_fast_array_builtins.

Yes, I plan to do that in a follow-on patch, but wanted to start with just
setting up things here (since not everything will work out trivially that way,
and some code needs to be moved between files). There's a TODO in src/js/i18n.js
for this plan.

https://codereview.chromium.org/2683083003/diff/80001/src/bootstrapper.cc#new...
src/bootstrapper.cc:4191: HARMONY_SHIPPING(INSTALL_EXPERIMENTAL_NATIVES);
On 2017/02/15 12:40:15, Yang wrote:
> Can we remove HARMONY_SHIPPING from here, so that in the future, moving a
> harmony feature to --harmony-shipping requires it to not tank start-up
> performance? Also please add a comment explaining this, here.

IMO we should be developing patches behind a flag with the same implementation
strategy as we eventually ship them with. In a follow-on patch, I'll remove the
remaining use of this feature, and with it, this whole mechanism.

https://codereview.chromium.org/2683083003/diff/80001/src/js/prologue.js
File src/js/prologue.js (right):

https://codereview.chromium.org/2683083003/diff/80001/src/js/prologue.js#newc...
src/js/prologue.js:204: function PostExperimentals(utils) {
On 2017/02/15 12:40:15, Yang wrote:
> We should figure out a way to not run this function anymore from the
> bootstrapper if no experimental script has run.

Rather than doing that, I was thinking of just getting rid of the final
remaining experimental script (part of SharedArrayBuffer) in a follow-on patch,
as you were suggesting. Then, we can just delete this code entirely.

[Dan Ehrenberg, 2017-02-15 16:43:42]

The CQ bit was checked by littledan@chromium.org

[Dan Ehrenberg, 2017-02-15 16:43:42]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2683083003/#ps100001
(title: "Changes based on review")

[commit-bot: I haz the power, 2017-02-15 16:43:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 17:36:25]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1487177022147050,
"parent_rev": "e7ebb930d1a293c03aea3d1ee0d57489afea68b8", "commit_rev":
"407d6bf16b37636dc2dfd91087a4e2b318ad2399"}

[commit-bot: I haz the power, 2017-02-15 17:36:31]

Description was changed from

==========
[bootstrapper] Remove Intl experimental natives files

These experimental natives previously only installed functions to the
appropriate parent. In this patch, the exports container is retained
so that the bootstrapper may install the functions instead. This
change is intended to reduce startup time. SharedArrayBuffer retains
some experimental natives exported from JS; this may be addressed
in a follow-on patch. The patch includes some minor cleanup of the
bootstrap process by removing "experimental exports", which was unused.

R=yangguo@chromium.org
BUG=v8:5880
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng
==========

to

==========
[bootstrapper] Remove Intl experimental natives files

These experimental natives previously only installed functions to the
appropriate parent. In this patch, the exports container is retained
so that the bootstrapper may install the functions instead. This
change is intended to reduce startup time. SharedArrayBuffer retains
some experimental natives exported from JS; this may be addressed
in a follow-on patch. The patch includes some minor cleanup of the
bootstrap process by removing "experimental exports", which was unused.

R=yangguo@chromium.org
BUG=v8:5880
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng

Review-Url: https://codereview.chromium.org/2683083003
Cr-Commit-Position: refs/heads/master@{#43221}
Committed:
https://chromium.googlesource.com/v8/v8/+/407d6bf16b37636dc2dfd91087a4e2b318a...
==========

[commit-bot: I haz the power, 2017-02-15 17:36:32]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/v8/v8/+/407d6bf16b37636dc2dfd91087a4e2b318a...