Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 2683053004: Make getUserMedia() ask for permission if video constraints cannot be satisfied. (Closed)

Created:
3 years, 10 months ago by Guido Urdaneta
Modified:
3 years, 10 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make getUserMedia() ask for permission if video constraints cannot be satisfied, except for the deviceID constraint. This is nonstandard behavior, but Hangouts relies on it. Will fix back once full spec-compliant constraint processing is implemented. BUG=690336 Review-Url: https://codereview.chromium.org/2683053004 Cr-Commit-Position: refs/heads/master@{#452122} Committed: https://chromium.googlesource.com/chromium/src/+/c726ced4178899d86c011f633ce793910dbec556

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M content/renderer/media/user_media_client_impl.cc View 1 chunk +17 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Guido Urdaneta
Hi, PTAL. Should we actually land this, which makes getUserMedia less spec compliant?
3 years, 10 months ago (2017-02-10 10:19:43 UTC) #6
Guido Urdaneta
Ping. Let's land this for M58 and revert the standard behavior in M59 together with ...
3 years, 10 months ago (2017-02-22 14:01:07 UTC) #8
tommi (sloooow) - chröme
sgtm lgtm
3 years, 10 months ago (2017-02-22 16:23:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683053004/1
3 years, 10 months ago (2017-02-22 16:51:00 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 18:00:45 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c726ced4178899d86c011f633ce7...

Powered by Google App Engine
This is Rietveld 408576698