Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 2683043004: Remove ui/events/blink dependency on blink_minimal. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
Reviewers:
Reid Kleckner, Nico, dcheng
CC:
chromium-reviews, tdresser+watch_chromium.org, dtapuska+chromiumwatch_chromium.org, abarth-chromium, dglazkov+blink, blink-reviews, blink-reviews-api_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ui/events/blink dependency on blink_minimal. It only needs blink_headers. WebCoalescedInputEvent was not an enum/POD so it shouldn't have been used outside of renderer. Fixed by: -moving ScopedWebInputEventWithLatencyInfo from content/common to content/renderer (its only user is there anyways) -hiding blink::WebScopedInputEvent from the public API and creating another version in ui/events/blink/web_input_events_traits. that file already has a duplicate of all the per-specific-type operations Also update blink_headers to include some headers it was missing, and the OWNERS file which was stale after gyp->gn conversion. BUG=248653 Review-Url: https://codereview.chromium.org/2683043004 Cr-Commit-Position: refs/heads/master@{#449631} Committed: https://chromium.googlesource.com/chromium/src/+/013b74c8a427c4ec9a5465a6060f626db8cacfd5

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : update blink_minimal #

Patch Set 4 : fix win debug #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -245 lines) Patch
M content/browser/devtools/protocol/input_handler.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/gesture_event_queue.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/common/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/common/input/event_with_latency_info.h View 1 1 chunk +1 line, -23 lines 0 comments Download
D content/common/input/event_with_latency_info.cc View 1 1 chunk +0 lines, -56 lines 0 comments Download
M content/common/input/input_event.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/input/input_param_traits.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M content/common/input/input_param_traits.cc View 1 2 chunks +9 lines, -9 lines 0 comments Download
M content/renderer/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/input/input_event_filter.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/input/input_event_filter.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/input/input_event_filter_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/input_handler_manager.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/input/input_handler_manager.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/input/input_handler_manager_client.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/input/input_handler_wrapper.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/input_handler_wrapper.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/main_thread_event_queue.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/input/main_thread_event_queue.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A content/renderer/input/scoped_web_input_event_with_latency_info.h View 1 1 chunk +45 lines, -0 lines 0 comments Download
A + content/renderer/input/scoped_web_input_event_with_latency_info.cc View 1 1 chunk +4 lines, -4 lines 2 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebCoalescedInputEvent.cpp View 1 4 chunks +29 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebInputEvent.cpp View 1 1 chunk +0 lines, -47 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/public/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebCoalescedInputEvent.h View 1 2 3 2 chunks +10 lines, -9 lines 2 comments Download
M third_party/WebKit/public/platform/WebInputEvent.h View 1 1 chunk +45 lines, -1 line 0 comments Download
M ui/events/blink/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/blink/DEPS View 1 1 chunk +1 line, -2 lines 0 comments Download
M ui/events/blink/event_with_callback.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M ui/events/blink/event_with_callback.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ui/events/blink/input_handler_proxy.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ui/events/blink/input_handler_proxy.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/events/blink/input_handler_proxy_client.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/events/blink/input_handler_proxy_unittest.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M ui/events/blink/web_input_event_traits.h View 1 2 chunks +8 lines, -3 lines 0 comments Download
M ui/events/blink/web_input_event_traits.cc View 1 4 chunks +22 lines, -5 lines 0 comments Download

Messages

Total messages: 41 (28 generated)
jam
3 years, 10 months ago (2017-02-09 20:52:52 UTC) #4
dcheng
Looks like the build is broken. I'll look again once it's green.
3 years, 10 months ago (2017-02-09 21:57:55 UTC) #7
jam
ah, yeah building chrome was fine, but the test target wasn't. investigating.
3 years, 10 months ago (2017-02-09 21:59:04 UTC) #8
jam
Daniel: ptal this should be ready now (verified all builds on win & linux locally) ...
3 years, 10 months ago (2017-02-10 00:26:36 UTC) #14
dcheng
lgtm https://codereview.chromium.org/2683043004/diff/60001/content/renderer/input/scoped_web_input_event_with_latency_info.cc File content/renderer/input/scoped_web_input_event_with_latency_info.cc (right): https://codereview.chromium.org/2683043004/diff/60001/content/renderer/input/scoped_web_input_event_with_latency_info.cc#newcode14 content/renderer/input/scoped_web_input_event_with_latency_info.cc:14: : event_(new blink::WebCoalescedInputEvent(*(event.get()))), Nit: I think *event should ...
3 years, 10 months ago (2017-02-10 10:17:26 UTC) #22
jam
https://codereview.chromium.org/2683043004/diff/60001/content/renderer/input/scoped_web_input_event_with_latency_info.cc File content/renderer/input/scoped_web_input_event_with_latency_info.cc (right): https://codereview.chromium.org/2683043004/diff/60001/content/renderer/input/scoped_web_input_event_with_latency_info.cc#newcode14 content/renderer/input/scoped_web_input_event_with_latency_info.cc:14: : event_(new blink::WebCoalescedInputEvent(*(event.get()))), On 2017/02/10 10:17:25, dcheng wrote: > ...
3 years, 10 months ago (2017-02-10 15:48:59 UTC) #23
Nico
On 2017/02/10 15:48:59, jam wrote: > https://codereview.chromium.org/2683043004/diff/60001/content/renderer/input/scoped_web_input_event_with_latency_info.cc > File content/renderer/input/scoped_web_input_event_with_latency_info.cc (right): > > https://codereview.chromium.org/2683043004/diff/60001/content/renderer/input/scoped_web_input_event_with_latency_info.cc#newcode14 > ...
3 years, 10 months ago (2017-02-10 15:59:25 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683043004/80001
3 years, 10 months ago (2017-02-10 16:23:52 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683043004/60001
3 years, 10 months ago (2017-02-10 16:30:54 UTC) #34
jam
On 2017/02/10 15:48:59, jam wrote: > https://codereview.chromium.org/2683043004/diff/60001/content/renderer/input/scoped_web_input_event_with_latency_info.cc > File content/renderer/input/scoped_web_input_event_with_latency_info.cc (right): > > https://codereview.chromium.org/2683043004/diff/60001/content/renderer/input/scoped_web_input_event_with_latency_info.cc#newcode14 > ...
3 years, 10 months ago (2017-02-10 16:30:59 UTC) #35
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/013b74c8a427c4ec9a5465a6060f626db8cacfd5
3 years, 10 months ago (2017-02-10 16:36:51 UTC) #38
Reid Kleckner
https://codereview.chromium.org/2683043004/diff/60001/third_party/WebKit/public/platform/WebCoalescedInputEvent.h File third_party/WebKit/public/platform/WebCoalescedInputEvent.h (right): https://codereview.chromium.org/2683043004/diff/60001/third_party/WebKit/public/platform/WebCoalescedInputEvent.h#newcode32 third_party/WebKit/public/platform/WebCoalescedInputEvent.h:32: struct WebInputEventDeleter { It looks like you need to ...
3 years, 10 months ago (2017-02-14 02:14:45 UTC) #40
dcheng
3 years, 10 months ago (2017-02-14 02:21:10 UTC) #41
Message was sent while issue was closed.
https://codereview.chromium.org/2683043004/diff/60001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/WebCoalescedInputEvent.h (right):

https://codereview.chromium.org/2683043004/diff/60001/third_party/WebKit/publ...
third_party/WebKit/public/platform/WebCoalescedInputEvent.h:32: struct
WebInputEventDeleter {
On 2017/02/14 02:14:45, Reid Kleckner wrote:
> It looks like you need to add BLINK_PLATFORM_EXPORT here to satisfy clang:
>
https://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%28dll%29/buil...

I think thakis already submitted a cl for this:
https://codereview.chromium.org/2694053003/

Powered by Google App Engine
This is Rietveld 408576698