Move SetUseOverrideRedirectWindowByDefault() to //ui/base.

Move SetUseOverrideRedirectWindowByDefault() to //ui/base.

There is a test related function SetUseOverrideRedirectWindowByDefault()
that is called from a various tests to change the override redirect
attribute when creating an XWindow. We normally want this attribute to
be false, except in some tests where it needs to be true. Not setting
this true causes problems depending on the X window manager and test
failures with Xvfb.

The calls to SetUseOverrideRedirectWindowByDefault() were guarded by
ifdef for USE_X11. This doesn't work for Ozone X11 because USE_X11=0. We
can't check at compile time if we need to call the function because the
Ozone platform isn't decided until runtime.

Instead, SetUseOverrideRedirectWindowByDefault() is moved into
//ui/base. All the function does is set a bool that can be queried when
creating a XWindow. X11WindowBase and WindowTreeHostX11 check the value.
In all other instances the bool is never used and has no effect.

BUG=690156
Review-Url: https://codereview.chromium.org/2683033006
Cr-Commit-Position: refs/heads/master@{#449767}
Committed: https://chromium.googlesource.com/chromium/src/+/e4030aee4483c7f90258ceb80c89bc3336ad92c3

[kylechar, 2017-02-09 19:27:14]

Patchset #2 (id:20001) has been deleted

[kylechar, 2017-02-09 19:36:36]

Description was changed from

==========
Move SetUseOverrideRedirectWindowByDefault() to //ui/base.

There is a test related function SetUseOverrideRedirectWindowByDefault()
that is called from a various tests to change the override redirect
attribute when creating an XWindow. We normally want this attribute to
be false, except in some tests where it needs to be true. This is highly
dependent on the X window manager but it definitely causes problems
running with Xvfb, which the trybots all use.

The calls to SetUseOverrideRedirectWindowByDefault() were guarded by
ifdef for USE_X11. This doesn't work for Ozone X11 because USE_X11=0. We
can't check at compile time if we need to call the function because the
Ozone platform isn't decided until runtime.

Instead, SetUseOverrideRedirectWindowByDefault() is moved into
//ui/base. All the function does is set a bool that can be queried when
creating a XWindow. X11WindowBase and WindowTreeHostX11 check the value.
In all other instances the bool is never used and has no effect.

BUG=690156
==========

to

==========
Move SetUseOverrideRedirectWindowByDefault() to //ui/base.

There is a test related function SetUseOverrideRedirectWindowByDefault()
that is called from a various tests to change the override redirect
attribute when creating an XWindow. We normally want this attribute to
be false, except in some tests where it needs to be true. Not setting
this true causes problems depending on the X window manager and test
failures with Xvfb.

The calls to SetUseOverrideRedirectWindowByDefault() were guarded by
ifdef for USE_X11. This doesn't work for Ozone X11 because USE_X11=0. We
can't check at compile time if we need to call the function because the
Ozone platform isn't decided until runtime.

Instead, SetUseOverrideRedirectWindowByDefault() is moved into
//ui/base. All the function does is set a bool that can be queried when
creating a XWindow. X11WindowBase and WindowTreeHostX11 check the value.
In all other instances the bool is never used and has no effect.

BUG=690156
==========

[kylechar, 2017-02-09 19:38:10]

kylechar@chromium.org changed reviewers:
+ sadrul@chromium.org

[sadrul, 2017-02-09 21:49:35]

https://codereview.chromium.org/2683033006/diff/40001/ui/base/platform_window...
File ui/base/platform_window_defaults.h (right):

https://codereview.chromium.org/2683033006/diff/40001/ui/base/platform_window...
ui/base/platform_window_defaults.h:24: UI_BASE_EXPORT void
SetUseOverrideRedirectWindowByDefault(
Maybe call this something different? like EnableTestConfiguration() or something
like that. It probably doesn't need to take an input param?

[kylechar, 2017-02-10 15:16:51]

Patchset #3 (id:30017) has been deleted

[kylechar, 2017-02-10 15:28:28]

Patchset #4 (id:90001) has been deleted

[kylechar, 2017-02-10 15:31:03]

https://codereview.chromium.org/2683033006/diff/40001/ui/base/platform_window...
File ui/base/platform_window_defaults.h (right):

https://codereview.chromium.org/2683033006/diff/40001/ui/base/platform_window...
ui/base/platform_window_defaults.h:24: UI_BASE_EXPORT void
SetUseOverrideRedirectWindowByDefault(
On 2017/02/09 21:49:35, sadrul wrote:
> Maybe call this something different? like EnableTestConfiguration() or
something
> like that. It probably doesn't need to take an input param?

Done.

[kylechar, 2017-02-10 20:09:59]

kylechar@chromium.org changed reviewers:
+ sky@chromium.org

[kylechar, 2017-02-10 20:10:00]

Changed the name as per IRC conversation.

+sky for ash/*, content/* and services/ui/*

[sadrul, 2017-02-10 20:44:42]

lgtm

https://codereview.chromium.org/2683033006/diff/130001/ui/base/platform_windo...
File ui/base/platform_window_defaults.cc (right):

https://codereview.chromium.org/2683033006/diff/130001/ui/base/platform_windo...
ui/base/platform_window_defaults.cc:10: bool g_override_redirect = false;
g_use_test_config!

[sky, 2017-02-10 21:11:23]

LGTM

[kylechar, 2017-02-10 21:15:30]

https://codereview.chromium.org/2683033006/diff/130001/ui/base/platform_windo...
File ui/base/platform_window_defaults.cc (right):

https://codereview.chromium.org/2683033006/diff/130001/ui/base/platform_windo...
ui/base/platform_window_defaults.cc:10: bool g_override_redirect = false;
On 2017/02/10 20:44:42, sadrul wrote:
> g_use_test_config!

Thanks, totally missed that.

[kylechar, 2017-02-10 21:16:07]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 21:16:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kylechar, 2017-02-10 22:16:17]

The CQ bit was unchecked by kylechar@chromium.org

[kylechar, 2017-02-10 22:16:17]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2017-02-10 22:16:18]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2683033006/#ps150001
(title: "g_use_test_config.")

[commit-bot: I haz the power, 2017-02-10 22:16:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 22:36:13]

CQ is committing da patch.

Bot data: {"patchset_id": 150001, "attempt_start_ts": 1486764977638990,
"parent_rev": "bf5431e05e9a2316842e3dda9068619e21070a82", "commit_rev":
"e4030aee4483c7f90258ceb80c89bc3336ad92c3"}

[commit-bot: I haz the power, 2017-02-10 22:36:44]

Description was changed from

==========
Move SetUseOverrideRedirectWindowByDefault() to //ui/base.

There is a test related function SetUseOverrideRedirectWindowByDefault()
that is called from a various tests to change the override redirect
attribute when creating an XWindow. We normally want this attribute to
be false, except in some tests where it needs to be true. Not setting
this true causes problems depending on the X window manager and test
failures with Xvfb.

The calls to SetUseOverrideRedirectWindowByDefault() were guarded by
ifdef for USE_X11. This doesn't work for Ozone X11 because USE_X11=0. We
can't check at compile time if we need to call the function because the
Ozone platform isn't decided until runtime.

Instead, SetUseOverrideRedirectWindowByDefault() is moved into
//ui/base. All the function does is set a bool that can be queried when
creating a XWindow. X11WindowBase and WindowTreeHostX11 check the value.
In all other instances the bool is never used and has no effect.

BUG=690156
==========

to

==========
Move SetUseOverrideRedirectWindowByDefault() to //ui/base.

There is a test related function SetUseOverrideRedirectWindowByDefault()
that is called from a various tests to change the override redirect
attribute when creating an XWindow. We normally want this attribute to
be false, except in some tests where it needs to be true. Not setting
this true causes problems depending on the X window manager and test
failures with Xvfb.

The calls to SetUseOverrideRedirectWindowByDefault() were guarded by
ifdef for USE_X11. This doesn't work for Ozone X11 because USE_X11=0. We
can't check at compile time if we need to call the function because the
Ozone platform isn't decided until runtime.

Instead, SetUseOverrideRedirectWindowByDefault() is moved into
//ui/base. All the function does is set a bool that can be queried when
creating a XWindow. X11WindowBase and WindowTreeHostX11 check the value.
In all other instances the bool is never used and has no effect.

BUG=690156

Review-Url: https://codereview.chromium.org/2683033006
Cr-Commit-Position: refs/heads/master@{#449767}
Committed:
https://chromium.googlesource.com/chromium/src/+/e4030aee4483c7f90258ceb80c89...
==========

[commit-bot: I haz the power, 2017-02-10 22:36:45]

Committed patchset #6 (id:150001) as
https://chromium.googlesource.com/chromium/src/+/e4030aee4483c7f90258ceb80c89...