Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2682943010: clang: Disable -Wblock-capture-autoreleasing (Closed)

Created:
3 years, 10 months ago by Nico
Modified:
3 years, 10 months ago
Reviewers:
hans
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang: Disable -Wblock-capture-autoreleasing This warning has existed for a while but used to be off-by-default. Upstream made it on-by-default recently, which breaks the compile step of the iOS ToT bot. BUG=691120 TBR=hans Review-Url: https://codereview.chromium.org/2682943010 Cr-Commit-Position: refs/heads/master@{#449837} Committed: https://chromium.googlesource.com/chromium/src/+/48130024a853818d09b132c10dfca934a14e7da6

Patch Set 1 #

Patch Set 2 : naaaaaacl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/config/compiler/BUILD.gn View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Nico
3 years, 10 months ago (2017-02-10 22:54:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2682943010/1
3 years, 10 months ago (2017-02-10 22:55:17 UTC) #5
hans
lgtm
3 years, 10 months ago (2017-02-10 22:56:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2682943010/20001
3 years, 10 months ago (2017-02-10 23:05:56 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-11 02:33:58 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/48130024a853818d09b132c10dfc...

Powered by Google App Engine
This is Rietveld 408576698