Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2682943007: [wasm] Refactoring: move bytecode operands into wasm-decoder-impl.h (Closed)

Created:
3 years, 10 months ago by titzer
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Refactoring: move bytecode operands into wasm-decoder-impl.h R=bradnelson@chromium.org,clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2682943007 Cr-Commit-Position: refs/heads/master@{#43077} Committed: https://chromium.googlesource.com/v8/v8/+/4f4da1f87d45925d8546b755baaf3f1140a4f8b3

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -497 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M src/wasm/function-body-decoder.h View 1 chunk +1 line, -286 lines 0 comments Download
M src/wasm/function-body-decoder.cc View 5 chunks +9 lines, -27 lines 0 comments Download
A + src/wasm/function-body-decoder-impl.h View 3 chunks +19 lines, -179 lines 1 comment Download
M src/wasm/module-decoder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/wasm/wasm-interpreter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/wasm/wasm-text.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/wasm/function-body-decoder-unittest.cc View 3 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
titzer
3 years, 10 months ago (2017-02-10 00:43:03 UTC) #1
titzer
https://codereview.chromium.org/2682943007/diff/1/src/wasm/function-body-decoder-impl.h File src/wasm/function-body-decoder-impl.h (right): https://codereview.chromium.org/2682943007/diff/1/src/wasm/function-body-decoder-impl.h#newcode1 src/wasm/function-body-decoder-impl.h:1: // Copyright 2017 the V8 project authors. All rights ...
3 years, 10 months ago (2017-02-10 00:45:34 UTC) #4
bradnelson
lgtm
3 years, 10 months ago (2017-02-10 01:01:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2682943007/1
3 years, 10 months ago (2017-02-10 01:15:00 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 01:16:43 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/4f4da1f87d45925d8546b755baaf3f1140a...

Powered by Google App Engine
This is Rietveld 408576698