Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2682913003:
WPT: Import mixed content, referrer policy, and SRI tests. (Closed)
DescriptionWPT: Import mixed content, referrer policy, and SRI tests.
R=foolip@chromium.org,jochen@chromium.org
Review-Url: https://codereview.chromium.org/2682913003
Cr-Commit-Position: refs/heads/master@{#449242}
Committed: https://chromium.googlesource.com/chromium/src/+/8b4749e153da27c06c59b5a104fcffd5164842b3
Patch Set 1 #
Total comments: 2
Patch Set 2 : s/eisinger/jochen/ #Patch Set 3 : Rebase #Messages
Total messages: 21 (11 generated)
The CQ bit was checked by mkwst@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Philip: Halp. :) Do I need to run the importer script? Will the bots automagically do so for me? Will I get a flood of test failures if some/all of the tests actually fail? There are probably docs for this, but I haven't found them. :(
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2682913003/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/W3CImportExpectations (right): https://codereview.chromium.org/2682913003/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/W3CImportExpectations:305: ## Owners: eisinger@chromium.org,estark@chromium.org jochen@chromium.org?
On 2017/02/08 12:06:16, Mike West (sloooooow) wrote: > Philip: Halp. :) > > Do I need to run the importer script? Will the bots automagically do so for me? > Will I get a flood of test failures if some/all of the tests actually fail? > > There are probably docs for this, but I haven't found them. :( You don't need to run the importer if you're not in a hurry, just unskipping and waiting is fine. The importer will mark tests as failing and then you can investigate. https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_plat... doesn't really spell this out, but would a sentence hidden in there have helped you?
lgtm qyearsley@, FYI that people are wondering about this. If you see someone else also wonder, maybe document it in https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_plat...
On 2017/02/08 at 13:23:39, foolip wrote: > On 2017/02/08 12:06:16, Mike West (sloooooow) wrote: > > Philip: Halp. :) > > > > Do I need to run the importer script? Will the bots automagically do so for me? > > Will I get a flood of test failures if some/all of the tests actually fail? > > > > There are probably docs for this, but I haven't found them. :( > > You don't need to run the importer if you're not in a hurry, just unskipping and waiting is fine. The importer will mark tests as failing and then you can investigate. Great! > https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_plat... doesn't really spell this out, but would a sentence hidden in there have helped you? I think so. I didn't find that file, but I should have. :)
lgtm with my correct mail address :) https://codereview.chromium.org/2682913003/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/W3CImportExpectations (right): https://codereview.chromium.org/2682913003/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/W3CImportExpectations:331: ## Owners: mkwst@chromium.org,eisinger@chromium.org same here ^^^
The CQ bit was checked by mkwst@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org, foolip@chromium.org Link to the patchset: https://codereview.chromium.org/2682913003/#ps20001 (title: "s/eisinger/jochen/")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by mkwst@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org, foolip@chromium.org Link to the patchset: https://codereview.chromium.org/2682913003/#ps40001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486626904289590,
"parent_rev": "4f94559a234a15ed12c9244ffee47279f5dca8a5", "commit_rev":
"8b4749e153da27c06c59b5a104fcffd5164842b3"}
Message was sent while issue was closed.
Description was changed from ========== WPT: Import mixed content, referrer policy, and SRI tests. R=foolip@chromium.org,jochen@chromium.org ========== to ========== WPT: Import mixed content, referrer policy, and SRI tests. R=foolip@chromium.org,jochen@chromium.org Review-Url: https://codereview.chromium.org/2682913003 Cr-Commit-Position: refs/heads/master@{#449242} Committed: https://chromium.googlesource.com/chromium/src/+/8b4749e153da27c06c59b5a104fc... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/8b4749e153da27c06c59b5a104fc... |
