MD Settings: Removing invalid selectors from language page tests.

MD Settings: Removing invalid selectors from language page tests.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2682893002
Cr-Commit-Position: refs/heads/master@{#449192}
Committed: https://chromium.googlesource.com/chromium/src/+/13084c992e7c9d28ecac0b5967e1cafaca49714d

[scottchen, 2017-02-08 00:42:08]

Description was changed from

==========
MD Settings: Fix language page unit tests

BUG=
==========

to

==========
MD Settings: Fix language page unit tests

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[scottchen, 2017-02-08 00:43:35]

scottchen@chromium.org changed reviewers:
+ dbeam@chromium.org, dpapad@chromium.org

[scottchen, 2017-02-08 00:44:04]

The CQ bit was checked by scottchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 00:44:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-02-08 00:55:58]

Can you rephrase the CL to "MD Settings: Removing invalid selectors from
language page tests."? Current wording makes it sound as if the tests are
currently failing.

[commit-bot: I haz the power, 2017-02-08 02:48:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 02:48:25]

Dry run: This issue passed the CQ dry run.

[scottchen, 2017-02-08 21:39:14]

Description was changed from

==========
MD Settings: Fix language page unit tests

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Removing invalid selectors from language page tests.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[scottchen, 2017-02-08 21:39:35]

On 2017/02/08 00:55:58, dpapad wrote:
> Can you rephrase the CL to "MD Settings: Removing invalid selectors from
> language page tests."? Current wording makes it sound as if the tests are
> currently failing.

Updated.

[dpapad, 2017-02-08 22:22:15]

LGTM with optional nit.

https://codereview.chromium.org/2682893002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/languages_page/languages_page.html
(right):

https://codereview.chromium.org/2682893002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/languages_page/languages_page.html:130: <a
is="action-link" class="list-button" id="addLanguagesButton"
Nit (optional): Unless there is a naming conflict, I suggest dropping the
"Button" suffix from the ID, I don't think we've been following this pattern in
our codebase (but we don't have a rule about it either ).

https://codereview.chromium.org/2682893002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/languages_page/languages_page.html:182:
id="manageInputMethodsButton"
Same here.

[Dan Beam, 2017-02-08 23:57:57]

dbeam@chromium.org changed reviewers:
- dbeam@chromium.org

[scottchen, 2017-02-09 01:19:14]

https://codereview.chromium.org/2682893002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/languages_page/languages_page.html
(right):

https://codereview.chromium.org/2682893002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/languages_page/languages_page.html:130: <a
is="action-link" class="list-button" id="addLanguagesButton"
On 2017/02/08 22:22:14, dpapad wrote:
> Nit (optional): Unless there is a naming conflict, I suggest dropping the
> "Button" suffix from the ID, I don't think we've been following this pattern
in
> our codebase (but we don't have a rule about it either ).

Done.

https://codereview.chromium.org/2682893002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/languages_page/languages_page.html:182:
id="manageInputMethodsButton"
On 2017/02/08 22:22:14, dpapad wrote:
> Same here.

Done.

[scottchen, 2017-02-09 01:19:17]

The CQ bit was checked by scottchen@chromium.org

[scottchen, 2017-02-09 01:19:18]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2682893002/#ps20001
(title: "Rename button ids")

[commit-bot: I haz the power, 2017-02-09 01:19:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 02:28:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486603157954290,
"parent_rev": "5821741047894731b6527b607edfb8ddef33fd1b", "commit_rev":
"13084c992e7c9d28ecac0b5967e1cafaca49714d"}

[commit-bot: I haz the power, 2017-02-09 02:29:12]

Description was changed from

==========
MD Settings: Removing invalid selectors from language page tests.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Removing invalid selectors from language page tests.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2682893002
Cr-Commit-Position: refs/heads/master@{#449192}
Committed:
https://chromium.googlesource.com/chromium/src/+/13084c992e7c9d28ecac0b5967e1...
==========

[commit-bot: I haz the power, 2017-02-09 02:29:13]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/13084c992e7c9d28ecac0b5967e1...