Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2682803004: Reland 'media: Add "Hide players" button in about://media-internals' with fix (Closed)

Created:
3 years, 10 months ago by xhwang
Modified:
3 years, 10 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland 'media: Add "Hide players" button in about://media-internals' with fix This relands 4ee2eeb27fb5cb49b1d5fa470528c16738d0274d with fix. Original CL description: What this does is: - Adds a button to hide all current players on the page, but doesn't touch the C++ side to actually delete those players. - After a player is hidden, new logs for that player will be dropped and will not resurrect any hidden players. - If a user refreshes the media-internals page, or open a new one, we'll get all players back. Fix: In manager.js, handle the case where the button may not exist, e.g. in tests. TBR=sandersd@chromium.org BUG=688607 Review-Url: https://codereview.chromium.org/2682803004 Cr-Commit-Position: refs/heads/master@{#449087} Committed: https://chromium.googlesource.com/chromium/src/+/46844f6e8ad264cd4b20a3d75c0d3a8c303333bb

Patch Set 1 : original CL #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M content/browser/resources/media/manager.js View 1 2 chunks +11 lines, -0 lines 0 comments Download
M content/browser/resources/media/media_internals.html View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2682803004/20001
3 years, 10 months ago (2017-02-08 20:43:57 UTC) #2
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 20:57:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/46844f6e8ad264cd4b20a3d75c0d...

Powered by Google App Engine
This is Rietveld 408576698